com php-src: Fix zlib/tests/gzseek to create unique temporary files: ext/zlib/tests/gzseek_basic2.phpt ext/zlib/tests/gzseek _variation1.phpt
ext/zlib/tests/gzseek_variation4 .phpt ext/zlib/tests/gzseek_variation5.phpt ext/zli b/tests/gzseek_variation7.phpt
| From: | Sara Golemon | Date: | Wed, 24 Apr 2013 08:06:55 +0000 |
| Subject: | com php-src: Fix zlib/tests/gzseek to create unique temporary files: ext/zlib/tests/gzseek_basic2.phpt ext/zlib/tests/gzseek _variation1.phpt ext/zlib/tests/gzseek_variation4 .phpt ext/zlib/tests/gzseek_variation5.phpt ext/zli b/tests/gzseek_variation7.phpt |
||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-72021@lists.php.net to get a copy of this message | ||
Commit: 22f6b6dbec4772febe0e3c31bceeb31eecf806ab
Author: ptarjan <ptarjan@fb.com> Thu, 25 Apr 2013 00:13:30 -0700
Committer: Sara Golemon <pollita@php.net> Wed, 24 Apr 2013 01:06:55 -0700
Parents: 4c0746228d51e58b47a661f9501503e29b1756f8
Branches: master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=22f6b6dbec4772febe0e3c31bceeb31eecf806ab
Log:
Fix zlib/tests/gzseek to create unique temporary files
When running tests in parallel these create a race condition.
Race conditions are bad.
Changed paths:
M ext/zlib/tests/gzseek_basic2.phpt
M ext/zlib/tests/gzseek_variation1.phpt
M ext/zlib/tests/gzseek_variation4.phpt
M ext/zlib/tests/gzseek_variation5.phpt
M ext/zlib/tests/gzseek_variation7.phpt
Diff:
diff --git a/ext/zlib/tests/gzseek_basic2.phpt b/ext/zlib/tests/gzseek_basic2.phpt
index a815b8f..82d305d 100644
--- a/ext/zlib/tests/gzseek_basic2.phpt
+++ b/ext/zlib/tests/gzseek_basic2.phpt
@@ -8,7 +8,7 @@ if (!extension_loaded("zlib")) {
?>
--FILE--
<?php
-$f = "temp3.txt.gz";
+$f = "gzseek_basic2.gz";
$h = gzopen($f, 'w');
$str1 = "This is the first line.";
$str2 = "This is the second line.";
@@ -39,4 +39,4 @@ reading the output file
This is the first line.
string(40) "0000000000000000000000000000000000000000"
This is the second line.
-===DONE===
\ No newline at end of file
+===DONE===
diff --git a/ext/zlib/tests/gzseek_variation1.phpt b/ext/zlib/tests/gzseek_variation1.phpt
index 301b57d..b260783 100644
--- a/ext/zlib/tests/gzseek_variation1.phpt
+++ b/ext/zlib/tests/gzseek_variation1.phpt
@@ -8,7 +8,7 @@ if (!extension_loaded("zlib")) {
?>
--FILE--
<?php
-$f = "temp3.txt.gz";
+$f = "gzseek_variation1.gz";
$h = gzopen($f, 'w');
$str1 = "This is the first line.";
$str2 = "This is the second line.";
@@ -30,4 +30,4 @@ unlink($f);
This is the first line.
string(40) "0000000000000000000000000000000000000000"
This is the second line.
-===DONE===
\ No newline at end of file
+===DONE===
diff --git a/ext/zlib/tests/gzseek_variation4.phpt b/ext/zlib/tests/gzseek_variation4.phpt
index fc641f6..3d0cf67 100644
--- a/ext/zlib/tests/gzseek_variation4.phpt
+++ b/ext/zlib/tests/gzseek_variation4.phpt
@@ -8,7 +8,7 @@ if (!extension_loaded("zlib")) {
?>
--FILE--
<?php
-$f = "temp3.txt.gz";
+$f = "gzseek_variation5.gz";
$h = gzopen($f, 'w');
$str1 = "This is the first line.";
$str2 = "This is the second line.";
@@ -39,4 +39,4 @@ reading the output file
This is the first line.
string(40) "0000000000000000000000000000000000000000"
This is the second line.
-===DONE===
\ No newline at end of file
+===DONE===
diff --git a/ext/zlib/tests/gzseek_variation5.phpt b/ext/zlib/tests/gzseek_variation5.phpt
index 0167e20..93fb19f 100644
--- a/ext/zlib/tests/gzseek_variation5.phpt
+++ b/ext/zlib/tests/gzseek_variation5.phpt
@@ -8,7 +8,7 @@ if (!extension_loaded("zlib")) {
?>
--FILE--
<?php
-$f = "temp3.txt.gz";
+$f = "gzseek_variation5.gz";
$h = gzopen($f, 'w');
$str1 = "This is the first line.";
$str2 = "This is the second line.";
@@ -39,4 +39,4 @@ reading the output file
This is the first line.
string(40) "0000000000000000000000000000000000000000"
This is the second line.
-===DONE===
\ No newline at end of file
+===DONE===
diff --git a/ext/zlib/tests/gzseek_variation7.phpt b/ext/zlib/tests/gzseek_variation7.phpt
index aab0834..a365272 100644
--- a/ext/zlib/tests/gzseek_variation7.phpt
+++ b/ext/zlib/tests/gzseek_variation7.phpt
@@ -8,7 +8,7 @@ if (!extension_loaded("zlib")) {
?>
--FILE--
<?php
-$f = "temp3.txt.gz";
+$f = "gzseek_variation7.gz";
$h = gzopen($f, 'w');
$str1 = "This is the first line.";
$str2 = "This is the second line.";
@@ -44,4 +44,4 @@ tell=int(47)
reading the output file
This is the first line.This is the second line.
-===DONE===
\ No newline at end of file
+===DONE===