Re: com php-src: Fix conversion from unsigned char to char: sapi/cgi/cgi_main.c
| From: | David Soria Parra | Date: | Mon, 29 Apr 2013 00:33:41 +0000 |
| Subject: | Re: com php-src: Fix conversion from unsigned char to char: sapi/cgi/cgi_main.c | ||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-72064@lists.php.net to get a copy of this message | ||
On 04/29/2013 12:49 AM, Stas Malyshev wrote:
> Hi!
>
>> Are you sure about this change?
>> Because this actually changes the semantics of the code. The following piece
>> of code will now evaluate differently than before:
>> *p <= ' '
>
> I also don't understand this change - this means 0xFF would now be
> skipped as space while before it was not. Is it the intended effect?
>
I reverted the change to make I dont break anything. The better option
would probably use the char * as it's passed and check for *p >= \0 &&
*p <= ' ',
David