Re: com php-src: Address feature request #38917 for native SPKAC (HTML5 keygen element) support: ext/openssl/openssl.c ext/openssl/php_openssl.h
ext/openssl/tests/openssl_spki_export.phpt ext/openssl/tests/openssl_spki_export_challenge.phpt ext/openssl/tests/openssl_spki_new.phpt
ext/openssl/tests/openssl_spki_verify.phpt
| From: | Kalle Sommer Nielsen | Date: | Thu, 09 May 2013 21:08:22 +0000 |
| Subject: | Re: com php-src: Address feature request #38917 for native SPKAC (HTML5 keygen element) support: ext/openssl/openssl.c ext/openssl/php_openssl.h ext/openssl/tests/openssl_spki_export.phpt ext/openssl/tests/openssl_spki_export_challenge.phpt ext/openssl/tests/openssl_spki_new.phpt ext/openssl/tests/openssl_spki_verify.phpt |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-72157@lists.php.net to get a copy of this message | ||
Hi Jason
2013/5/7 Jason Gerfen <jas@php.net>:
> Commit: 8f56ac8401ed1c3e00b8fba3fb8e5efb565180c4
> Author: jas- <jason.gerfen@gmail.com> Mon, 6 May 2013 16:36:06 -0600
> Parents: da07e91c3a7e7bac2e380f24c59f70c1bcb3e7e4
> Branches: master
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=8f56ac8401ed1c3e00b8fba3fb8e5efb565180c4
>
> Log:
> Address feature request #38917 for native SPKAC (HTML5 keygen element) support
>
> Bugs:
> https://bugs.php.net/38917
+ ASN1_STRING_set(spki->spkac->challenge, challenge, (int)strlen(challenge));
Since we don't modify challenge here, wouldn't be smarter to use
challenge_len we already get from zend_parse_parameters() or did I
miss something? =P
--
regards,
Kalle Sommer Nielsen
kalle@php.net