com php-src: Fixed bug #62857 (bytea test failures): ext/pgsql/tests/10pg_convert_85.phpt ext/pgsql/ tests/12pg_insert_85.phpt ext/pgsql/tests/1
4pg_update_85.phpt ext/pgsql/tests/18pg_esc ape_bytea.phpt
| From: | Matteo Beccati | Date: | Sat, 01 Jun 2013 21:15:48 +0000 |
| Subject: | com php-src: Fixed bug #62857 (bytea test failures): ext/pgsql/tests/10pg_convert_85.phpt ext/pgsql/ tests/12pg_insert_85.phpt ext/pgsql/tests/1 4pg_update_85.phpt ext/pgsql/tests/18pg_esc ape_bytea.phpt |
||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-72274@lists.php.net to get a copy of this message | ||
Commit: 79803bebdea2827d66c0f96fd3dbaf4a2747ff27
Author: Matteo Beccati <mbeccati@php.net> Sat, 1 Jun 2013 23:15:48 +0200
Parents: 598e2690b81a145589f6dfe06f77d9e3b66a7853
Branches: PHP-5.3 PHP-5.4 PHP-5.5 master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=79803bebdea2827d66c0f96fd3dbaf4a2747ff27
Log:
Fixed bug #62857 (bytea test failures)
Postgres 9.1+ test fixes. Tests were failing due to the default
standard_conforming_strings GUC being changed to on. Also the
pg_escape_bytea test was encoding the data before estabilishing
a connection, thus falling back to the old escaping type which
isn't properly handled by the backend when using a default
configuration.
I haven't updated the NEWS file as it's just test fixes.
Bugs:
https://bugs.php.net/62857
Changed paths:
M ext/pgsql/tests/10pg_convert_85.phpt
M ext/pgsql/tests/12pg_insert_85.phpt
M ext/pgsql/tests/14pg_update_85.phpt
M ext/pgsql/tests/18pg_escape_bytea.phpt
Diff:
diff --git a/ext/pgsql/tests/10pg_convert_85.phpt b/ext/pgsql/tests/10pg_convert_85.phpt
index 4f1c92b..8b1cc8f 100644
--- a/ext/pgsql/tests/10pg_convert_85.phpt
+++ b/ext/pgsql/tests/10pg_convert_85.phpt
@@ -12,6 +12,7 @@ error_reporting(E_ALL);
include 'config.inc';
$db = pg_connect($conn_str);
+pg_query($db, "SET standard_conforming_strings = 0");
$fields = array('num'=>'1234', 'str'=>'AAA',
'bin'=>'BBB');
$converted = pg_convert($db, $table_name, $fields);
diff --git a/ext/pgsql/tests/12pg_insert_85.phpt b/ext/pgsql/tests/12pg_insert_85.phpt
index a85dea0..5fbbe4b 100644
--- a/ext/pgsql/tests/12pg_insert_85.phpt
+++ b/ext/pgsql/tests/12pg_insert_85.phpt
@@ -12,6 +12,8 @@ error_reporting(E_ALL);
include 'config.inc';
$db = pg_connect($conn_str);
+pg_query($db, "SET standard_conforming_strings = 0");
+
$fields = array('num'=>'1234', 'str'=>'AAA',
'bin'=>'BBB');
pg_insert($db, $table_name, $fields) or print "Error in test 1\n";
diff --git a/ext/pgsql/tests/14pg_update_85.phpt b/ext/pgsql/tests/14pg_update_85.phpt
index f1c77ea..06ca8c3 100644
--- a/ext/pgsql/tests/14pg_update_85.phpt
+++ b/ext/pgsql/tests/14pg_update_85.phpt
@@ -12,6 +12,8 @@ error_reporting(E_ALL);
include 'config.inc';
$db = pg_connect($conn_str);
+pg_query($db, "SET standard_conforming_strings = 0");
+
$fields = array('num'=>'1234', 'str'=>'ABC',
'bin'=>'XYZ');
$ids = array('num'=>'1234');
diff --git a/ext/pgsql/tests/18pg_escape_bytea.phpt b/ext/pgsql/tests/18pg_escape_bytea.phpt
index 43f98c4..5f52a17 100644
--- a/ext/pgsql/tests/18pg_escape_bytea.phpt
+++ b/ext/pgsql/tests/18pg_escape_bytea.phpt
@@ -8,10 +8,11 @@ PostgreSQL pg_escape_bytea() functions
include('config.inc');
+$db = pg_connect($conn_str);
+
$image = file_get_contents(dirname(__FILE__) . '/php.gif');
$esc_image = pg_escape_bytea($image);
-$db = pg_connect($conn_str);
pg_query($db, 'INSERT INTO '.$table_name.' (num, bin) VALUES (9876,
\''.$esc_image.'\');');
$result = pg_query($db, 'SELECT * FROM '.$table_name.' WHERE num = 9876');
$rows = pg_fetch_all($result);