Re: com php-src: BC fix for PR 109 merge - create_sid() method in SessionHandler: ext/session/php_session.h ext/session/session.c
ext/session/tests/session_set_save_handler_class_002.phpt ext/session/tests/session_set_save_handler_class_016.phpt
ext/session/tests/session_set_save_handler_class_017.phpt ext/session/tests/session_set_save_handler_iface_001.phpt
ext/session/tests/session_set_save_handler_iface_003.phpt ext/session/tests/session_set_save
| From: | Nikita Popov | Date: | Thu, 27 Jun 2013 14:12:21 +0000 |
| Subject: | Re: com php-src: BC fix for PR 109 merge - create_sid() method in SessionHandler: ext/session/php_session.h ext/session/session.c ext/session/tests/session_set_save_handler_class_002.phpt ext/session/tests/session_set_save_handler_class_016.phpt ext/session/tests/session_set_save_handler_class_017.phpt ext/session/tests/session_set_save_handler_iface_001.phpt ext/session/tests/session_set_save_handler_iface_003.phpt ext/session/tests/session_set_save |
||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-72532@lists.php.net to get a copy of this message | ||
On Thu, Jun 27, 2013 at 3:47 PM, Arpad Ray <arraypad@gmail.com> wrote:
> On Thu, Jun 27, 2013 at 2:39 PM, Nikita Popov <nikita.ppv@gmail.com>wrote:
>
>> On Thu, Jun 27, 2013 at 1:33 PM, Arpad Ray <arpad@php.net> wrote:
>>
>>> Creates a new SessionIdInterface and moves create_sid() into it, so
>>> existing
>>> handlers implementing SessionHandlerInterface don't require create_sid().
>>> SessionHandler still includes the method so the default mod can be
>>> called, but
>>> now implements both interfaces.
>>>
>>
>> I'd appreciate some different name for this interface. "SessionID extends
>> SessionHandler" makes pretty little sense to me.
>>
>> Nikita
>>
>
> I'm not sure what you mean, usage looks like:
>
> class MyHandler extends SessionHandler
> (or) class MyHandler implements SessionHandlerInterface
> (or now) class MyHandler implements SessionHandlerInterface,
> SessionIdInterface
>
Ooops, sorry. I misunderstood the purpose of the interface :/ Everything's
all right :)
Nikita