Re: com php-src: Allow 'make distclean' to clean up the 'generated' phar.inc: Makefile.global ext/phar/Makefile.frag ext/phar/phar/phar.inc
ext/phar/phar/phar.inc.in
| From: | Johannes Schlüter | Date: | Thu, 01 Aug 2013 03:12:42 +0000 |
| Subject: | Re: com php-src: Allow 'make distclean' to clean up the 'generated' phar.inc: Makefile.global ext/phar/Makefile.frag ext/phar/phar/phar.inc ext/phar/phar/phar.inc.in |
||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-72799@lists.php.net to get a copy of this message | ||
On Thu, 2013-08-01 at 04:59 +0200, Johannes Schlüter wrote:
> On Wed, 2013-07-31 at 19:31 +0000, Christopher Jones wrote:
> > Commit: 017145bc57e604153f2a2400dd6e73a397f52f96
> > Author: Christopher Jones <sixd@php.net> Wed, 31 Jul 2013 12:31:50 -0700
> > Parents: 4ed18d5955ad7ac0172f6eec87735fefcd113270
> > Branches: PHP-5.5 master
> >
> > Link:
> > http://git.php.net/?p=php-src.git;a=commitdiff;h=017145bc57e604153f2a2400dd6e73a397f52f96
> >
> > Log:
> > Allow 'make distclean' to clean up the 'generated' phar.inc
>
> This seems to be the wrong "fix" for the actual issue.
Adding this to Makefile.global after reverting this commit might be
better:
if test $(builddir) != $(srcdir); then \
rm ext/phar/phar/phar.inc; \
fi;
(untested)
While I still wonder why we have to copy the file to the builddir at
all ..
johannes