cvs: php4 /ext/domxml php_domxml.c

sterling Sun Sep 9 05:41:40 2001 EDT Modified files: /php4/ext/domxml php_domxml.c Log: Change DOM-XML's error reporting to E_WARNING which is more appropriate Index: php4/ext/domxml/php_domxml.c diff -u php4/ext/domxml/php_domxml.c:1.70 php4/ext/domxml/php_domxml.c:1.71 --- php4/ext/domxml/php_domxml.c:1.70 Wed Aug 29 18:26:04 2001 +++ php4/ext/domxml/php_domxml.c Sun Sep 9 05:41:40 2001 @@ -16,7 +16,7 @@ +----------------------------------------------------------------------+ */ -/* $Id: php_domxml.c,v 1.70 2001/08/29 22:26:04 joey Exp $ */ +/* $Id: php_domxml.c,v 1.71 2001/09/09 09:41:40 sterling Exp $ */ #ifdef HAVE_CONFIG_H @@ -393,16 +393,19 @@ TSRMLS_FETCH(); if (Z_TYPE_P(wrapper) != IS_OBJECT) { - php_error(E_ERROR, "Wrapper is not an object"); + php_error(E_WARNING, "Wrapper is not an object"); + return NULL; } if (zend_hash_index_find(Z_OBJPROP_P(wrapper), 0, (void **) &handle) == FAILURE) { - php_error(E_ERROR, "Underlying object missing"); + php_error(E_WARNING, "Underlying object missing"); + return NULL; } obj = zend_list_find(Z_LVAL_PP(handle), &type); if (!obj || ((type != rsrc_type1) && (type != rsrc_type2))) { - php_error(E_ERROR, "Underlying object missing or of invalid type"); + php_error(E_WARNING, "Underlying object missing or of invalid type"); + return NULL; } return obj; @@ -493,17 +496,20 @@ int type; if (Z_TYPE_P(wrapper) != IS_OBJECT) { - php_error(E_ERROR, "Wrapper is not an object"); + php_error(E_WARNING, "Wrapper is not an object"); + return NULL; } if (zend_hash_index_find(Z_OBJPROP_P(wrapper), 0, (void **) &handle) == FAILURE) { - php_error(E_ERROR, "Underlying object missing"); + php_error(E_WARNING, "Underlying object missing"); + return NULL; } obj = zend_list_find(Z_LVAL_PP(handle), &type); if (!obj || ((type != rsrc_type1) && (type != rsrc_type2))) { - php_error(E_ERROR, "Underlying object missing or of invalid type"); + php_error(E_WARNING, "Underlying object missing or of invalid type"); + return NULL; } return obj; @@ -591,18 +597,21 @@ int type; if (Z_TYPE_P(wrapper) != IS_OBJECT) { - php_error(E_ERROR, "Wrapper is not an object"); + php_error(E_WARNING, "Wrapper is not an object"); + return NULL; } if (zend_hash_index_find(Z_OBJPROP_P(wrapper), 0, (void **) &handle) == FAILURE) { - php_error(E_ERROR, "Underlying object missing"); + php_error(E_WARNING, "Underlying object missing"); + return NULL; } obj = zend_list_find(Z_LVAL_PP(handle), &type); /* The following test should be replaced with search in all parents */ if (!obj) { /* || ((type != rsrc_type1) && (type != rsrc_type2))) { */ - php_error(E_ERROR, "Underlying object missing or of invalid type"); + php_error(E_WARNING, "Underlying object missing or of invalid type"); + return NULL; } return obj; @@ -953,6 +962,9 @@ id = getThis(); attrp = php_dom_get_object(id, le_domxmlattrp, 0 TSRMLS_CC); + if (!attrp) { + RETURN_FALSE; + } RETURN_STRING((char *) (attrp->name), 1); } @@ -2562,7 +2574,7 @@ id = getThis(); if (!id) { - php_error(E_ERROR, "Invalid object"); + php_error(E_WARNING, "Invalid object"); RETURN_FALSE; } @@ -2637,6 +2649,9 @@ ctxp = php_xpath_get_context(id, le_xpathctxp, 0 TSRMLS_CC); + if (!ctxp) { + RETURN_FALSE; + } convert_to_string(str); if (contextnode) {