Re: com php-src: DNS name comparison is now case insensitive.: ext/openssl/openssl.c ext/openssl/tests/bug65729.phpt
| From: | Michael Wallner | Date: | Tue, 08 Oct 2013 15:50:36 +0000 |
| Subject: | Re: com php-src: DNS name comparison is now case insensitive.: ext/openssl/openssl.c ext/openssl/tests/bug65729.phpt | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-73401@lists.php.net to get a copy of this message | ||
On 8 October 2013 16:54, Johannes Schlüter <johannes@schlueters.de> wrote:
> Hi,
>
> On Tue, 2013-10-08 at 02:07 +0000, Michael Wallner wrote:
>>
>> Log:
>> DNS name comparison is now case insensitive.
>
>> - if (strcmp(subjectname, certname) == 0) {
>> + if (strcasecmp(subjectname, certname) == 0) {
>
> Shouldn't that use an non-locale-dependent (ASCII based) comparison?
> Else we get into trouble with the famous tolower(toupper('i')) != 'i'
> issue in Turkish locales.
Thanks for the catch!
--
Regards,
Mike