Re: com php-src: more fixes to spl: ext/spl/spl_directory.c ext/spl/spl_directory.h ext/spl/spl_dllist.c ext/spl/spl_engine.c ext/spl/spl_engine.h
ext/spl/spl_functions.h ext/spl/spl_heap.c ext/spl/spl_observer.c ext/spl/tests/bug64782.phpt
| From: | Anatol Belski | Date: | Tue, 12 Nov 2013 16:46:31 +0000 |
| Subject: | Re: com php-src: more fixes to spl: ext/spl/spl_directory.c ext/spl/spl_directory.h ext/spl/spl_dllist.c ext/spl/spl_engine.c ext/spl/spl_engine.h ext/spl/spl_functions.h ext/spl/spl_heap.c ext/spl/spl_observer.c ext/spl/tests/bug64782.phpt |
||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-73942@lists.php.net to get a copy of this message | ||
Hi Peter,
On Tue, November 12, 2013 15:24, Peter Cowburn wrote:
> On 12 November 2013 09:56, Anatol Belski <ab@php.net> wrote:
>
>
>> Commit: ef1c2ffaf0f68a0779fc88ad46486de59d67bf6a
>> Author: Anatol Belski <ab@php.net> Tue, 12 Nov 2013 10:56:01
>> +0100
>> Parents: ae1fb8dc4b49cf40642181e08180ad81c0607484
>> Branches: str_size_and_int64
>>
>>
>> Link:
>>
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=ef1c2ffaf0f68a0779fc88a
>> d46486de59d67bf6a
>>
>> Log:
>> more fixes to spl
>>
>
> Thanks for your hard work "fixing" lots of code, but please could you try
> to make the commit messages at least a little bit descriptive? Having a
> whole heap of "fixed <something>" commit messages isn't useful to man
> nor beast.
>
> Keep up the good work! :)
>
>
>
>>
>> Changed paths:
>> M ext/spl/spl_directory.c
>> M ext/spl/spl_directory.h
>> M ext/spl/spl_dllist.c
>> M ext/spl/spl_engine.c
>> M ext/spl/spl_engine.h
>> M ext/spl/spl_functions.h
>> M ext/spl/spl_heap.c
>> M ext/spl/spl_observer.c
>> M ext/spl/tests/bug64782.phpt
>>
>>
>>
great one keeps an eye on it :)
Many changes are kind of trivial, but some of more complicated ones should
be explained better. I'll improve that part, better commit messages will
be for sure useful.
Thanks
Anatol