Re: com php-src: Implemented FR #65917 (getallheaders() is not supported by the built-in...): NEWS UPGRADING sapi/cgi/cgi_main.c
sapi/cli/php_cli_server.c sapi/cli/tests/php_cli_server_019.phpt
| From: | Hannes Magnusson | Date: | Wed, 20 Nov 2013 06:54:08 +0000 |
| Subject: | Re: com php-src: Implemented FR #65917 (getallheaders() is not supported by the built-in...): NEWS UPGRADING sapi/cgi/cgi_main.c sapi/cli/php_cli_server.c sapi/cli/tests/php_cli_server_019.phpt |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-74003@lists.php.net to get a copy of this message | ||
On Tue, Nov 12, 2013 at 12:27 PM, <ajf@php.net> wrote:
> Commit: aee271ec0d30c332bed32b5eca1fdff1cb447eab
> Author: Andrea Faulds <ajf@ajf.me> Thu, 17 Oct 2013 22:19:09 +0000
> Parents: 1984919ddc3252c0f9b5d5d0beef10bdc4804091
> Branches: PHP-5.5
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=aee271ec0d30c332bed32b5eca1fdff1cb447eab
>
> Log:
> Implemented FR #65917 (getallheaders() is not supported by the built-in...)
>
> - Implemented apache_request_headers() and getallheaders() alias in CLI server
> - Implemented apache_response_headers() in CLI server using FastCGI code
>
> Conflicts:
> NEWS
> UPGRADING
>
> Bugs:
> https://bugs.php.net/65917
>
> Changed paths:
> M NEWS
> M UPGRADING
> M sapi/cgi/cgi_main.c
> M sapi/cli/php_cli_server.c
> A sapi/cli/tests/php_cli_server_019.phpt
>
>
>
> +PHP_FUNCTION(apache_request_headers) /* {{{ */
> +{
Please include the standard proto comments.
I'm also confused why its a good idea to add a new function and an
alias for that function..
That seems to just encourage confusion.
-Hannes