Re: cvs: php4 /ext/ldap ldap.c

On Wed, Sep 19, 2001 at 07:44:00PM -0000, Stig Venaas wrote: > venaas Wed Sep 19 15:44:00 2001 EDT > > Modified files: > /php4/ext/ldap ldap.c > Log: > Not using _free_ldap_result destructor for le_result_entry, leads to > crashes due to freeing same memory several times in some cases IMHU the zend_register_list_destructors_ex is teh way to do it - please explain. tc > > > Index: php4/ext/ldap/ldap.c > diff -u php4/ext/ldap/ldap.c:1.95 php4/ext/ldap/ldap.c:1.96 > --- php4/ext/ldap/ldap.c:1.95 Sun Sep 9 09:28:54 2001 > +++ php4/ext/ldap/ldap.c Wed Sep 19 15:43:59 2001 > @@ -22,7 +22,7 @@ > +----------------------------------------------------------------------+ > */ > > -/* $Id: ldap.c,v 1.95 2001/09/09 13:28:54 derick Exp $ */ > +/* $Id: ldap.c,v 1.96 2001/09/19 19:43:59 venaas Exp $ */ > #define IS_EXT_MODULE > > #ifdef HAVE_CONFIG_H > @@ -207,7 +207,7 @@ > > le_result = zend_register_list_destructors_ex(_free_ldap_result, NULL, "ldap > result", module_number); > le_link = zend_register_list_destructors_ex(_close_ldap_link, NULL, "ldap link", > module_number); > - le_result_entry = zend_register_list_destructors_ex(_free_ldap_result, NULL, "ldap > result entry", module_number); > + le_result_entry = zend_register_list_destructors_ex(NULL, NULL, "ldap result > entry", module_number); > > ldap_module_entry.type = type; > > @@ -251,7 +251,7 @@ > > php_info_print_table_start(); > php_info_print_table_row(2, "LDAP Support", "enabled" ); > - php_info_print_table_row(2, "RCS Version", "$Id: ldap.c,v 1.95 2001/09/09 > 13:28:54 derick Exp $" ); > + php_info_print_table_row(2, "RCS Version", "$Id: ldap.c,v 1.96 2001/09/19 > 19:43:59 venaas Exp $" ); > php_info_print_table_row(2, "Total Links", maxl ); > > #ifdef LDAP_API_VERSION > > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, e-mail: php-cvs-unsubscribe@lists.php.net > For additional commands, e-mail: php-cvs-help@lists.php.net > To contact the list administrators, e-mail: php-list-admin@lists.php.net >