Re: cvs: php4 /ext/zip zip.c
| From: | Sterling Hughes | Date: | Wed, 26 Sep 2001 15:39:20 +0000 |
| Subject: | Re: cvs: php4 /ext/zip zip.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-7571@lists.php.net to get a copy of this message | ||
On Wed, 26 Sep 2001, Jeroen van Wolffelaar wrote:
> jeroen Wed Sep 26 05:09:40 2001 EDT
>
> Modified files:
> /php4/ext/zip zip.c
> Log:
> Fix build
>
Didn't you mean 'break the build', your assigning a pointer to an
long value, the build wasn't broken here in the first place, the
correct patch would be:
RETURN_BOOL(entry->fp ? 1 : 0);
or just leave it how it is....
-Sterling
>
> Index: php4/ext/zip/zip.c
> diff -u php4/ext/zip/zip.c:1.18 php4/ext/zip/zip.c:1.19
> --- php4/ext/zip/zip.c:1.18 Sun Sep 9 09:29:25 2001
> +++ php4/ext/zip/zip.c Wed Sep 26 05:09:40 2001
> @@ -16,7 +16,7 @@
> +----------------------------------------------------------------------+
> */
>
> -/* $Id: zip.c,v 1.18 2001/09/09 13:29:25 derick Exp $ */
> +/* $Id: zip.c,v 1.19 2001/09/26 09:09:40 jeroen Exp $ */
>
> #include "php.h"
> #include "php_ini.h"
> @@ -260,10 +260,7 @@
>
> entry->fp = zzip_file_open(archive_p, entry->dirent.d_name, O_RDONLY | O_BINARY);
>
> - if (entry->fp)
> - RETURN_TRUE;
> - else
> - RETURN_FALSE;
> + RETURN_BOOL(entry->fp);
> }
> /* }}} */
>
>
>
>
>