com php-src: document more on --zpp-vars: compat/PECL_PORTING
| From: | Anatol Belski | Date: | Thu, 30 Jan 2014 20:50:46 +0000 |
| Subject: | com php-src: document more on --zpp-vars: compat/PECL_PORTING | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-75868@lists.php.net to get a copy of this message | ||
Commit: d82da76d1998d5457ed6e892e35a11ded4853c01
Author: Anatol Belski <ab@php.net> Thu, 30 Jan 2014 21:50:46 +0100
Parents: e56176479cec2959b938d9f119b25f391b1e8933
Branches: str_size_and_int64
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=d82da76d1998d5457ed6e892e35a11ded4853c01
Log:
document more on --zpp-vars
Changed paths:
M compat/PECL_PORTING
Diff:
diff --git a/compat/PECL_PORTING b/compat/PECL_PORTING
index 7bfe746..fc3dea9 100644
--- a/compat/PECL_PORTING
+++ b/compat/PECL_PORTING
@@ -112,7 +112,9 @@ II. Porting steps
--macros replace old vs. new macro/function names
--zpp replace "lLsp" with "iISP" at appropriate places only
--zpp-compat replace things like
- "slO" with (PHP_NEED_STRSIZE_COMPAT ? "slO" : "SiO")
+ "slO" with ZPP_FMT_COMPAT("slO", "SiO")
+ --zpp-vars replace datatypes for vars passed to zpp calls. Dont expect this
+ this option to be the swiss knife! Verify after it!
The macro and zpp options are separated and don't have to be used together.
@@ -120,10 +122,15 @@ II. Porting steps
<str_size_and_int64>.
You can also use --reverse if you want to have all the changes back to old. One
- exception though is when the --zpp-compat is used - this case isn't yet
- implemented as if some used a custom macros name instead of
- PHP_NEED_STRSIZE_COMPAT or some other custom #ifdef, it will be hard to catch.
- Though it should be implemented to cover the standard case.
+ exception though is when --zpp-compat or --zpp-vars is used - this case isn't
+ yet implemented. For instance, if some used a custom macros name instead of
+ ZPP_FMT_COMPAT or some other custom #ifdef, it will be hard to catch.
+
+ The replacements with --zpp-vars might go totally insane depending on code
+ formatting, so revert might be too complex. However one var daclaration per
+ line should be very good replaceable. Also, --zpp-vars will give you some
+ warnings where it couldn't replace the corresponding var type, despite it could
+ be parsed, you should go through those.
ii. Compatibility header