Re: com php-src: imagettftext() uses the last charactermap it found and not the one you want: NEWS ext/gd/libgd/gd.h ext/gd/libgd/gdft.c
ext/gd/tests/Rochester-Regular.otf ext/gd/tests/Rochester-Regular.otf.LICENSE.txt ext/gd/tests/imagettftext_charmap_order.phpt

Hi Scott, Good enough for now, thanks :) Did you forget to test the MacRoman in fontTest? It would be great if you coould provide a PR in bitbuckket's repo too, which hhvm would most likely follow too :) Cheers, On Mon, Feb 17, 2014 at 7:49 AM, Scott MacVicar <scottmac@php.net> wrote: > Commit: 796bfb0bd000f7d9d23e633a965f6a8a77a5e927 > Author: Scott MacVicar <scottmac@php.net> Sun, 16 Feb 2014 21:53:19 -0800 > Parents: 1f3af9cd2152f08bb52bb69d035a4aefdd9d13bf > Branches: master > > Link: > http://git.php.net/?p=php-src.git;a=commitdiff;h=796bfb0bd000f7d9d23e633a965f6a8a77a5e927 > > Log: > imagettftext() uses the last charactermap it found and not the one you want > > Summary: > This caused issues when you picked a font with multiple maps, it wouldn't > pick the unicode version but instead pick the last one it saw. Change so > we cache on a per encoding level. There was even a todo list item in the code. > > In an ideal world we can probably iterate through at font write time. > > Test Plan: > See said unit test, it's Apache Licensed font included > > Changed paths: > M NEWS > M ext/gd/libgd/gd.h > M ext/gd/libgd/gdft.c > A ext/gd/tests/Rochester-Regular.otf > A ext/gd/tests/Rochester-Regular.otf.LICENSE.txt > A ext/gd/tests/imagettftext_charmap_order.phpt > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php -- Pierre @pierrejoye | http://www.libgd.org