Re: com php-src: Use nicer output for characters < 32 and > 126 in exception strings Using question marks might confuse more than it helps. Users are
wondering what happened to their string...: Zend/zend_exceptions.c
| From: | Ferenc Kovacs | Date: | Thu, 27 Feb 2014 01:02:18 +0000 |
| Subject: | Re: com php-src: Use nicer output for characters < 32 and > 126 in exception strings Using question marks might confuse more than it helps. Users are wondering what happened to their string...: Zend/zend_exceptions.c |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-76247@lists.php.net to get a copy of this message | ||
On Thu, Feb 20, 2014 at 5:39 PM, Bob Weinand <bwoebi@php.net> wrote:
> Commit: afa03a470ef90a53f2b59a8175f77afdb6b5a651
> Author: Bob Weinand <bobwei9@hotmail.com> Thu, 20 Feb 2014
> 17:39:58 +0100
> Parents: 633f898f1520253d3530fe91fc82f68bca7c4627
> Branches: PHP-5.4
>
> Link:
>
> http://git.php.net/?p=php-src.git;a=commitdiff;h=afa03a470ef90a53f2b59a8175f77afdb6b5a6519
> fºÓýÄ#Ô ~R?0@
>
> Log:
> Use nicer output for characters < 32 and > 126 in exception strings
> Using question marks might confuse more than it helps.
> Users are wondering what happened to their string...
>
> Changed paths:
> M Zend/zend_exceptions.c
>
>
Hi Bob,
there are a couple of tests failing for me, seemingly related to this
change.
for example:
ReflectionClass::getStaticPropertyValue()
[ext/reflection/tests/ReflectionClass_getStaticPropertyValue_001_2_4.phpt]
006+ #0
/Users/tyrael/checkouts/php-src.git/ext/reflection/tests/ReflectionClass_getStaticPropertyValue_001_2_4.php(17):
ReflectionClass->getStaticPropertyValue('\x00A\x00privateOverr...')
006- #0 %sReflectionClass_getStaticPropertyValue_001_2_4.php(%d):
ReflectionClass->getStaticPropertyValue('?A?privateOverr...')%
ReflectionClass::setStaticPropertyValue()
[ext/reflection/tests/ReflectionClass_setStaticPropertyValue_001_2_4.phpt]
005+ #0
/Users/tyrael/checkouts/php-src.git/ext/reflection/tests/ReflectionClass_setStaticPropertyValue_001_2_4.php(16):
ReflectionClass->setStaticPropertyValue('\x00A\x00privateOverr...', 'new
value 1')
005- #0 %sReflectionClass_setStaticPropertyValue_001_2_4.php(%d):
ReflectionClass->setStaticPropertyValue('?A?privateOverr...', 'new value
1')%
Bug #54291 (Crash iterating DirectoryIterator for dir name starting with
\0) [ext/spl/tests/bug54291.phpt]
003+ #0 /Users/tyrael/checkouts/php-src.git/ext/spl/tests/bug54291.php(2):
DirectoryIterator->__construct('\x00/abc')
003- #0 %s(%d): DirectoryIterator->__construct('?/abc')%
Those test should need to be updated to the new representation, right?
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu