Re: com php-src: Do not remove *.1, it's not generated by make but configure: Makefile.global
| From: | Laruence | Date: | Mon, 10 Mar 2014 08:46:54 +0000 |
| Subject: | Re: com php-src: Do not remove *.1, it's not generated by make but configure: Makefile.global | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-76404@lists.php.net to get a copy of this message | ||
On Mon, Mar 10, 2014 at 4:32 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> Hi Xinchen,
>
> On Mon, Mar 10, 2014 at 4:54 PM, Xinchen Hui <laruence@php.net> wrote:
>>
>> Commit: a930e047927835db02325e0e7a0ae48da00649e0
>> Author: Xinchen Hui <laruence@php.net> Mon, 10 Mar 2014
>> 15:54:20 +0800
>> Parents: 972935cd957ed626fcdb66f0e770ae6c429156d4
>> Branches: PHP-5.5 PHP-5.6 master
>>
>> Link:
>>
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=a930e047927835db02325e0e7a0ae48da00649e0
>>
>> Log:
>> Do not remove *.1, it's not generated by make but configure
>>
>
> Understandable change, but I think manuals should be generated by make. I
> wander why they are generated by configure. They should be ignored by git at
> least.
Hey
they are in gitinore list..
thanks
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>
>
>>
>> Changed paths:
>> M Makefile.global
>>
>>
>> Diff:
>> diff --git a/Makefile.global b/Makefile.global
>> index 40fadcc..05c5d15 100644
>> --- a/Makefile.global
>> +++ b/Makefile.global
>> @@ -115,7 +115,6 @@ clean:
>> find . -name \*.la -o -name \*.a | xargs rm -f
>> find . -name \*.so | xargs rm -f
>> find . -name .libs -a -type d|xargs rm -rf
>> - find . -name \*.1 | xargs rm -f
>> rm -f libphp$(PHP_MAJOR_VERSION).la $(SAPI_CLI_PATH)
>> $(SAPI_CGI_PATH) $(SAPI_MILTER_PATH) $(SAPI_LITESPEED_PATH) $(SAPI_FPM_PATH)
>> $(OVERALL_TARGET) modules/* libs/*
>>
>> distclean: clean
>>
>>
>> --
>> PHP CVS Mailing List (http://www.php.net/)
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>
--
Laruence Xinchen Hui
http://www.laruence.com/