Re: com php-src: Add a test: ext/mysqli/tests/mysqli_begin_transaction.phpt

thanks! On Thu, Mar 20, 2014 at 2:19 PM, Andrey Hristov <php@hristov.com> wrote: > Hi Ferenc, > yes, I saw it today. I am working on it. > > Thanks! > > Andrey > > > On 20.03.2014 10:29, Ferenc Kovacs wrote: > >> On Tue, Mar 18, 2014 at 2:42 PM, Andrey Hristov <andrey@php.net> wrote: >> >> Commit: 2b811a5aec81595a9f3c704e3a5b813636ede1b4 >>> Author: Andrey Hristov <andrey@php.net> Tue, 18 Mar 2014 >>> 15:42:38 +0200 >>> Parents: 156cc39e21cb5badbad11d42b5aa37e7b917f2a5 >>> Branches: PHP-5.5 PHP-5.6 master >>> >>> Link: >>> http://git.php.net/?p=php-src.git;a=commitdiff;h= >>> 2b811a5aec81595a9f3c704e3a5b813636ede1b4 >>> >>> Log: >>> Add a test >>> >>> Changed paths: >>> A ext/mysqli/tests/mysqli_begin_transaction.phpt >>> >>> >>> Diff: >>> diff --git a/ext/mysqli/tests/mysqli_begin_transaction.phpt >>> b/ext/mysqli/tests/mysqli_begin_transaction.phpt >>> new file mode 100644 >>> index 0000000..24e8d3c >>> --- /dev/null >>> +++ b/ext/mysqli/tests/mysqli_begin_transaction.phpt >>> @@ -0,0 +1,140 @@ >>> +--TEST-- >>> +mysqli_begin_transaction() >>> +--SKIPIF-- >>> +<?php >>> +require_once('skipif.inc'); >>> +require_once('skipifemb.inc'); >>> +require_once('skipifconnectfailure.inc'); >>> + >>> +require_once('connect.inc'); >>> +if (!$link = my_mysqli_connect($host, $user, $passwd, $db, $port, >>> $socket)) >>> + die(sprintf("Cannot connect, [%d] %s", mysqli_connect_errno(), >>> mysqli_connect_error())); >>> + >>> +if (!have_innodb($link)) >>> + die(sprintf("Needs InnoDB support, [%d] %s", $link->errno, >>> $link->error)); >>> +?> >>> +--FILE-- >>> +<?php >>> + require_once("connect.inc"); >>> + /* {{{ proto bool mysqli_begin_transaction(object link, [int >>> flags >>> [, string name]]) */ >>> + $tmp = NULL; >>> + $link = NULL; >>> + >>> + if (!is_null($tmp = @mysqli_begin_transaction())) >>> + printf("[001] Expecting NULL, got %s/%s\n", >>> gettype($tmp), >>> $tmp); >>> + >>> + if (!is_null($tmp = @mysqli_begin_transaction($link))) >>> + printf("[002] Expecting NULL, got %s/%s\n", >>> gettype($tmp), >>> $tmp); >>> + >>> + if (!is_null($tmp = @mysqli_begin_transaction($link, $link))) >>> + printf("[003] Expecting NULL, got %s/%s\n", >>> gettype($tmp), >>> $tmp); >>> + >>> + if (!$link = my_mysqli_connect($host, $user, $passwd, $db, $port, >>> $socket)) >>> + printf("[004] Cannot connect to the server using host=%s, >>> user=%s, passwd=***, dbname=%s, port=%s, socket=%s\n", >>> + $host, $user, $db, $port, $socket); >>> + >>> + if (!is_null($tmp = @mysqli_begin_transaction($link, $link))) >>> + printf("[005] Expecting NULL, got %s/%s\n", >>> gettype($tmp), >>> $tmp); >>> + >>> + if (!is_null($tmp = @mysqli_begin_transaction($link, 0, $link))) >>> + printf("[006] Expecting NULL, got %s/%s\n", >>> gettype($tmp), >>> $tmp); >>> + >>> + if (!is_null($tmp = @mysqli_begin_transaction($link, 0, "mytrx", >>> $link))) >>> + printf("[007] Expecting NULL, got %s/%s\n", >>> gettype($tmp), >>> $tmp); >>> + >>> + if (!mysqli_query($link, 'DROP TABLE IF EXISTS test')) >>> + printf("[008] [%d] %s\n", mysqli_errno($link), >>> mysqli_error($link)); >>> + >>> + if (!mysqli_query($link, 'CREATE TABLE test(id INT) ENGINE = >>> InnoDB')) >>> + printf("[009] Cannot create test table, [%d] %s\n", >>> mysqli_errno($link), mysqli_error($link)); >>> + >>> + if (true !== ($tmp = mysqli_autocommit($link, true))) >>> + printf("[010] Cannot turn on autocommit, expecting true, >>> got %s/%s\n", gettype($tmp), $tmp); >>> + >>> + /* overrule autocommit */ >>> + if (true !== ($tmp = mysqli_begin_transaction($link))) >>> + printf("[011] Got %s - [%d] %s\n", var_dump($tmp, true), >>> mysqli_errno($link), mysqli_error($link)); >>> + >>> + if (!mysqli_query($link, 'INSERT INTO test(id) VALUES (1)')) >>> + printf("[012] [%d] %s\n", mysqli_errno($link), >>> mysqli_error($link)); >>> + >>> + $tmp = mysqli_rollback($link); >>> + if ($tmp !== true) >>> + printf("[013] Expecting boolean/true, got %s/%s\n", >>> gettype($tmp), $tmp); >>> + >>> + /* empty */ >>> + $res = mysqli_query($link, "SELECT * FROM test"); >>> + var_dump($res->fetch_assoc()); >>> + >>> + /* valid flags */ >>> + $flags = array( >>> + MYSQLI_TRANS_START_WITH_CONSISTENT_SNAPSHOT, >>> + MYSQLI_TRANS_START_READ_WRITE, >>> + MYSQLI_TRANS_START_READ_ONLY, >>> + MYSQLI_TRANS_COR_AND_CHAIN, >>> + MYSQLI_TRANS_COR_AND_NO_CHAIN, >>> + MYSQLI_TRANS_COR_RELEASE, >>> + MYSQLI_TRANS_COR_NO_RELEASE); >>> + >>> + /* just coverage */ >>> + foreach ($flags as $flag) { >>> + if (!mysqli_begin_transaction($link, $flag, >>> sprintf("flag >>> %d", $flag))) { >>> + printf("[014] [%d] %s\n", mysqli_errno($link), >>> mysqli_error($link)); >>> + } >>> + if (!mysqli_query($link, 'SELECT * FROM test') || >>> + !mysqli_rollback($link)) { >>> + printf("[015] [%d] %s\n", mysqli_errno($link), >>> mysqli_error($link)); >>> + } >>> + } >>> + >>> + /* does it really set a flag? */ >>> + if (mysqli_get_server_version($link) >= 50600) { >>> + if (!mysqli_begin_transaction($link, >>> MYSQLI_TRANS_START_READ_ONLY, sprintf("flag %d", $flag))) { >>> + printf("[016] [%d] %s\n", mysqli_errno($link), >>> mysqli_error($link)); >>> + } >>> + if (!mysqli_query($link, "INSERT INTO test(id) VALUES >>> (2)") || >>> + !mysqli_commit($link)) { >>> + printf("[017] [%d] %s\n", mysqli_errno($link), >>> mysqli_error($link)); >>> + } else { >>> + $res = mysqli_query($link, "SELECT id FROM test >>> WHERE id = 2"); >>> + var_dump($res->fetch_assoc()); >>> + } >>> + } >>> + >>> + /* invalid flag */ >>> + do { >>> + $invalid_flag = mt_rand(0, 10000); >>> + } while (isset(array_flip($flags)[$invalid_flag])); >>> + /* we may or may not hit an invalid combination provoking a SQL >>> error */ >>> + if (!mysqli_begin_transaction($link, $invalid_flag, >>> sprintf("flag >>> %d", $invalid_flag))) { >>> + printf("[018] invalid_flag = %d [%d] %s\n", >>> $invalid_flag, >>> mysqli_errno($link), mysqli_error($link)); >>> + } else { >>> + printf("[018] invalid_flag = %d [%d] %s\n", >>> $invalid_flag, >>> mysqli_errno($link), mysqli_error($link)); >>> + } >>> + if (!mysqli_begin_transaction($link, -1)) { >>> + printf("[019] [%d] %s\n", mysqli_errno($link), >>> mysqli_error($link)); >>> + } >>> + >>> + /* does it like stupid names? */ >>> + if (!$link->begin_transaction(MYSQLI_TRANS_START_READ_WRITE, >>> "*/trick me?\n\0")) >>> + printf("[020] [%d] %s\n", mysqli_errno($link), >>> mysqli_error($link)); >>> + >>> + /* does it like stupid names? */ >>> + if (!$link->begin_transaction(MYSQLI_TRANS_START_READ_WRITE, >>> "az09")) >>> + printf("[021] [%d] %s\n", mysqli_errno($link), >>> mysqli_error($link)); >>> + >>> + print "done!"; >>> +?> >>> +--CLEAN-- >>> +<?php >>> + require_once("clean_table.inc"); >>> +?> >>> +--EXPECTF-- >>> +NULL >>> +[017] [1792] %s >>> +[018] invalid_flag = %d [%d]%A >>> + >>> +Warning: mysqli_begin_transaction(): Invalid value for parameter flags >>> (-1) in %s on line %d >>> +[019] [%d]%A >>> +[020] [%d]%A >>> +done! >>> \ No newline at end of file >>> >>> >>> -- >>> PHP CVS Mailing List (http://www.php.net/) >>> To unsubscribe, visit: http://www.php.net/unsub.php >>> >>> >>> Hi Andrey, >> >> This test contains mysql features only present in mysql >= 5.6, could you >> please execute those only when the test server supports them? >> Here is an example where the test fails: >> https://travis-ci.org/php/php-src/builds/21145878 >> >> TEST 4955/12227 [ext/mysqli/tests/mysqli_begin_transaction.phpt] >> ========DIFF======== >> 002+ [014] [1064] You have an error in your SQL syntax; check the manual >> that corresponds to your MySQL server version for the right syntax to use >> near 'READ WRITE' at line 1 >> 003+ [014] [1064] You have an error in your SQL syntax; check the manual >> that corresponds to your MySQL server version for the right syntax to use >> near 'READ ONLY' at line 1 >> 004+ [014] [1064] You have an error in your SQL syntax; check the manual >> that corresponds to your MySQL server version for the right syntax to use >> near 'READ WRITE' at line 1 >> 005+ [014] [1064] You have an error in your SQL syntax; check the manual >> that corresponds to your MySQL server version for the right syntax to use >> near 'READ ONLY' at line 1 >> 002- [017] [1792] %s >> 011+ */ READ WRITE' at line 1 >> 012+ [021] [1064] You have an error in your SQL syntax; check the manual >> that corresponds to your MySQL server version for the right syntax to use >> near 'READ WRITE' at line 1 >> ========DONE======== >> >> > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Ferenc Kovács @Tyr43l - http://tyrael.hu