Re: com php-src: Add default_charset handling: ext/standard/html.c ext/standard/tests/strings/default_charset.phpt
| From: | Yasuo Ohgaki | Date: | Fri, 21 Mar 2014 00:00:59 +0000 |
| Subject: | Re: com php-src: Add default_charset handling: ext/standard/html.c ext/standard/tests/strings/default_charset.phpt | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-76563@lists.php.net to get a copy of this message | ||
On Thu, Mar 20, 2014 at 8:57 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:
> Why do you use estrndup in get_charset, just to efree it here? Can't you
> just directly return it and avoid an alloc/free cycle on the charset string?
I'll check it. I think it can be removed.
Thank you for the comment.
--
Yasuo Ohgaki
yohgaki@ohgaki.net