Re: com php-src: fix tests broken by 633f898f1520253d3530fe91fc82f68bca7c4627:
ext/reflection/tests/ReflectionClass_getStaticPropertyValue_001_2_4.phpt ext/reflection/tests/ReflectionClass_setStaticPropertyValue_001_2_4.phpt
ext/spl/tests/bug54291.phpt
| From: | Remi Collet | Date: | Thu, 03 Apr 2014 06:08:52 +0000 |
| Subject: | Re: com php-src: fix tests broken by 633f898f1520253d3530fe91fc82f68bca7c4627: ext/reflection/tests/ReflectionClass_getStaticPropertyValue_001_2_4.phpt ext/reflection/tests/ReflectionClass_setStaticPropertyValue_001_2_4.phpt ext/spl/tests/bug54291.phpt |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-76688@lists.php.net to get a copy of this message | ||
Le 27/02/2014 02:31, Ferenc Kovacs a écrit :
> Commit: bd961f3e873f71c1408111da065d94cd0c6527d9
> Author: Ferenc Kovacs <tyrael@php.net> Thu, 27 Feb 2014 02:31:42 +0100
> Parents: 4d9c556b5d4f0a04a42d1cc4dc0ac6cadd2e198a
> Branches: PHP-5.4
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=bd961f3e873f71c1408111da065d94cd0c6527d9
>
> Log:
> fix tests broken by 633f898f1520253d3530fe91fc82f68bca7c4627
>
> Changed paths:
> M ext/reflection/tests/ReflectionClass_getStaticPropertyValue_001_2_4.phpt
> M ext/reflection/tests/ReflectionClass_setStaticPropertyValue_001_2_4.phpt
> M ext/spl/tests/bug54291.phpt
>
Those tests are failing in 5.4.27 and 5.5.11
TEST FAILURE:
../ext/reflection/tests/ReflectionClass_setStaticPropertyValue_001_2_4.diff
--
005+ #0
/builddir/build/BUILD/php-5.5.11/ext/reflection/tests/ReflectionClass_setStaticPropertyValue_001_2_4.php(16):
ReflectionClass->setStaticPropertyValue('\x00A\x00pAipAieOverr...', 'new
value 1')
005- #0 %sReflectionClass_setStaticPropertyValue_001_2_4.php(%d):
ReflectionClass->setStaticPropertyValue('\x00A\x00privateOverr...', 'new
value 1')
TEST FAILURE:
../ext/reflection/tests/ReflectionClass_getStaticPropertyValue_001_2_4.diff
--
006+ #0
/builddir/build/BUILD/php-5.5.11/ext/reflection/tests/ReflectionClass_getStaticPropertyValue_001_2_4.php(17):
ReflectionClass->getStaticPropertyValue('\x00A\x00pAipAieOverr...')
006- #0 %sReflectionClass_getStaticPropertyValue_001_2_4.php(%d):
ReflectionClass->getStaticPropertyValue('\x00A\x00privateOverr...')
Any idea ?
Rmei
>
> Diff:
> diff --git a/ext/reflection/tests/ReflectionClass_getStaticPropertyValue_001_2_4.phpt
> b/ext/reflection/tests/ReflectionClass_getStaticPropertyValue_001_2_4.phpt
> index c299412..8bb62d9 100644
> --- a/ext/reflection/tests/ReflectionClass_getStaticPropertyValue_001_2_4.phpt
> +++ b/ext/reflection/tests/ReflectionClass_getStaticPropertyValue_001_2_4.phpt
> @@ -56,6 +56,6 @@ string(13) "default value"
>
> Fatal error: Uncaught exception 'ReflectionException' with message 'Class A
> does not have a property named ' in %sReflectionClass_getStaticPropertyValue_001_2_4.php:%d
> Stack trace:
> -#0 %sReflectionClass_getStaticPropertyValue_001_2_4.php(%d):
> ReflectionClass->getStaticPropertyValue('?A?privateOverr...')
> +#0 %sReflectionClass_getStaticPropertyValue_001_2_4.php(%d):
> ReflectionClass->getStaticPropertyValue('\x00A\x00privateOverr...')
> #1 {main}
> thrown in %sReflectionClass_getStaticPropertyValue_001_2_4.php on line %d
> diff --git a/ext/reflection/tests/ReflectionClass_setStaticPropertyValue_001_2_4.phpt
> b/ext/reflection/tests/ReflectionClass_setStaticPropertyValue_001_2_4.phpt
> index 1092f65..dc13bf5 100644
> --- a/ext/reflection/tests/ReflectionClass_setStaticPropertyValue_001_2_4.phpt
> +++ b/ext/reflection/tests/ReflectionClass_setStaticPropertyValue_001_2_4.phpt
> @@ -56,6 +56,6 @@ Set static values in A:
>
> Fatal error: Uncaught exception 'ReflectionException' with message 'Class A
> does not have a property named ' in %sReflectionClass_setStaticPropertyValue_001_2_4.php:%d
> Stack trace:
> -#0 %sReflectionClass_setStaticPropertyValue_001_2_4.php(%d):
> ReflectionClass->setStaticPropertyValue('?A?privateOverr...', 'new value 1')
> +#0 %sReflectionClass_setStaticPropertyValue_001_2_4.php(%d):
> ReflectionClass->setStaticPropertyValue('\x00A\x00privateOverr...', 'new value
> 1')
> #1 {main}
> thrown in %sReflectionClass_setStaticPropertyValue_001_2_4.php on line %d
> diff --git a/ext/spl/tests/bug54291.phpt b/ext/spl/tests/bug54291.phpt
> index b8f596e..9314b6b 100644
> --- a/ext/spl/tests/bug54291.phpt
> +++ b/ext/spl/tests/bug54291.phpt
> @@ -7,7 +7,7 @@ $dir->isFile();
> --EXPECTF--
> Fatal error: Uncaught exception 'UnexpectedValueException' with message 'Failed
> to open directory ""' in %s:%d
> Stack trace:
> -#0 %s(%d): DirectoryIterator->__construct('?/abc')
> +#0 %s(%d): DirectoryIterator->__construct('\x00/abc')
> #1 {main}
> thrown in %s on line %d
>
>