Re: com php-src: multibytes tests still fail, put them in XFAIL: ext/mbstring/tests/zend_multibyte-02.phpt ext/mbstring/tests/zend_multibyte-06.phpt
ext/mbstring/tests/zend_multibyte-08.phpt ext/mbstring/tests/zend_multibyte-10.phpt ext/mbstring/tests/zend_multibyte-11.phpt

On Sun, Apr 6, 2014 at 3:34 AM, Stanislav Malyshev <stas@php.net> wrote: > Commit: cf910f351ab7d8a55aba1aa717056ca2576a629b > Author: Stanislav Malyshev <stas@php.net> Sat, 5 Apr 2014 > 18:34:39 -0700 > Parents: 12e222ee9148ea919e10ab6af4d4da164200eda7 > Branches: PHP-5.6 master > > Link: > > http://git.php.net/?p=php-src.git;a=commitdiff;h=cf910f351ab7d8a55aba1aa717056ca2576a629b > > Log: > multibytes tests still fail, put them in XFAIL > > clean up XFAIL from tests no longer failing > > Changed paths: > M ext/mbstring/tests/zend_multibyte-02.phpt > M ext/mbstring/tests/zend_multibyte-06.phpt > M ext/mbstring/tests/zend_multibyte-08.phpt > M ext/mbstring/tests/zend_multibyte-10.phpt > M ext/mbstring/tests/zend_multibyte-11.phpt > > > Diff: > diff --git a/ext/mbstring/tests/zend_multibyte-02.phpt > b/ext/mbstring/tests/zend_multibyte-02.phpt > index 8a1a572..ebc10b4 100644 > --- a/ext/mbstring/tests/zend_multibyte-02.phpt > +++ b/ext/mbstring/tests/zend_multibyte-02.phpt > @@ -1,5 +1,7 @@ > --TEST-- > zend multibyte (2) > +--XFAIL-- > +https://bugs.php.net/bug.php?id=66582 > --INI-- > zend.multibyte=On > zend.script_encoding=UTF-8 > diff --git a/ext/mbstring/tests/zend_multibyte-06.phpt > b/ext/mbstring/tests/zend_multibyte-06.phpt > index 1b8adb5..e0b4ead 100644 > --- a/ext/mbstring/tests/zend_multibyte-06.phpt > +++ b/ext/mbstring/tests/zend_multibyte-06.phpt > @@ -1,5 +1,7 @@ > --TEST-- > zend multibyte (6) > +--XFAIL-- > +https://bugs.php.net/bug.php?id=66582 > --INI-- > zend.multibyte=On > zend.script_encoding=EUC-JP > diff --git a/ext/mbstring/tests/zend_multibyte-08.phpt > b/ext/mbstring/tests/zend_multibyte-08.phpt > index a0989fc..9e5b75e 100644 > --- a/ext/mbstring/tests/zend_multibyte-08.phpt > +++ b/ext/mbstring/tests/zend_multibyte-08.phpt > @@ -1,8 +1,5 @@ > --TEST-- > zend multibyte (8) > ---SKIPIF-- > ---XFAIL-- > -https://bugs.php.net/bug.php?id=66582 > --INI-- > zend.multibyte=On > zend.script_encoding=ISO-8859-1 > diff --git a/ext/mbstring/tests/zend_multibyte-10.phpt > b/ext/mbstring/tests/zend_multibyte-10.phpt > index 712757c..138b489 100644 > --- a/ext/mbstring/tests/zend_multibyte-10.phpt > +++ b/ext/mbstring/tests/zend_multibyte-10.phpt > @@ -1,8 +1,5 @@ > --TEST-- > zend multibyte (10) > ---SKIPIF-- > ---XFAIL-- > -https://bugs.php.net/bug.php?id=66582 > --INI-- > zend.multibyte=1 > --FILE-- > diff --git a/ext/mbstring/tests/zend_multibyte-11.phpt > b/ext/mbstring/tests/zend_multibyte-11.phpt > index 69624ae..6844d06 100644 > --- a/ext/mbstring/tests/zend_multibyte-11.phpt > +++ b/ext/mbstring/tests/zend_multibyte-11.phpt > @@ -1,8 +1,5 @@ > --TEST-- > zend multibyte (11) > ---SKIPIF-- > ---XFAIL-- > -https://bugs.php.net/bug.php?id=66582 > --INI-- > zend.multibyte=1 > --FILE-- > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > Hi Stas, FYI three of those previously XFAILS are leaking for me (hence failing when testing with --enable-debug): ext/mbstring/tests/zend_multibyte-08.phpt ext/mbstring/tests/zend_multibyte-10.phpt ext/mbstring/tests/zend_multibyte-11.phpt -- Ferenc Kovács @Tyr43l - http://tyrael.hu