Re: cvs: php4 /ext/standard array.c

Also, zend_hash_get_current_key_ex returns the strlen+1 as 5th parameter. I would help a lot if the synopsis of zend-functions was added just above the the function itself, together with things like it duplicates or not. (though not relevant for zend_hash_get_current_key_ex, but it is relevant in a lot of other cases) Open souce is good, but it shouldn't be source alone. The documentation doesn't go into details like this. Actually there's a comment that zend_hash_get_current_key_ex isn't binary safe... but that's all. Anyway, tests are very important for functions like in_array and array_search, it's a kind of documentation-by-example. (which can be checked more easily than you can check .xml documentation...) --Jeroen