Re: com php-src: Fixed bug #67081 DOMDocumentType->internalSubset returns entire DOCTYPE tag, not only the subset: NEWS ext/dom/documenttype.c
ext/dom/tests/DOMDocumentType_basic_001.phpt ext/dom/tests/bug67081.phpt ext/dom/tests/bug67081_0.xml ext/dom/tests/bug67081_1.xml
ext/dom/tests/bug67081_2.xml
| From: | Michael Wallner | Date: | Wed, 16 Apr 2014 12:57:27 +0000 |
| Subject: | Re: com php-src: Fixed bug #67081 DOMDocumentType->internalSubset returns entire DOCTYPE tag, not only the subset: NEWS ext/dom/documenttype.c ext/dom/tests/DOMDocumentType_basic_001.phpt ext/dom/tests/bug67081.phpt ext/dom/tests/bug67081_0.xml ext/dom/tests/bug67081_1.xml ext/dom/tests/bug67081_2.xml |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-76921@lists.php.net to get a copy of this message | ||
Hi Anatol!
On 16 April 2014 14:13, Anatol Belski <ab@php.net> wrote:
> Commit: 5224614f23eff18419f2c5489bebe60562e0ce2a
> Author: Anatol Belski <ab@php.net> Wed, 16 Apr 2014 14:13:45 +0200
> Parents: 1d34d822315a97bb7d3eeb3b9e75f34807ac4a12
> Branches: PHP-5.4 PHP-5.5 PHP-5.6 master
>
> Link:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=5224614f23eff18419f2c5489bebe60562e0ce2a
>
> Log:
> Fixed bug #67081 DOMDocumentType->internalSubset returns entire DOCTYPE tag, not only the
> subset
>
> Bugs:
> https://bugs.php.net/67081
> #ifdef LIBXML2_NEW_BUFFER
> - ZVAL_STRINGL(*retval, xmlOutputBufferGetContent(buff),
> xmlOutputBufferGetSize(buff), 1);
> + smart_str_appendl(ret_buf, xmlOutputBufferGetContent(buff),
> xmlOutputBufferGetSize(buff));
> #else
> - ZVAL_STRINGL(*retval, buff->buffer->content,
> buff->buffer->use, 1);
> + smart_str_appendl(&ret_buf, buff->buffer->content,
> buff->buffer->use);
> #endif
This is broken (&ret_buf vs ret_buf):
--
Regards,
Mike