com php-src: Fixed memleak in quote: ext/pdo/pdo_dbh.c
| From: | Dmitry Stogov | Date: | Fri, 25 Apr 2014 03:04:11 +0000 |
| Subject: | com php-src: Fixed memleak in quote: ext/pdo/pdo_dbh.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-77287@lists.php.net to get a copy of this message | ||
Commit: 1ccc250c5049521cf3c3c8058fcde2a9dc4403cb
Author: Xinchen Hui <laruence@gmail.com> Fri, 25 Apr 2014 11:04:11 +0800
Parents: 911d58de37152ac58934deafdf26049e9f0c0c72
Branches: phpng
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=1ccc250c5049521cf3c3c8058fcde2a9dc4403cb
Log:
Fixed memleak in quote
Changed paths:
M ext/pdo/pdo_dbh.c
Diff:
diff --git a/ext/pdo/pdo_dbh.c b/ext/pdo/pdo_dbh.c
index f75738c..b6cf026 100644
--- a/ext/pdo/pdo_dbh.c
+++ b/ext/pdo/pdo_dbh.c
@@ -1178,8 +1178,9 @@ static PHP_METHOD(PDO, quote)
}
if (dbh->methods->quoter(dbh, str, str_len, &qstr, &qlen, paramtype TSRMLS_CC)) {
- //??? memleak
- RETURN_STRINGL(qstr, qlen);
+ RETVAL_STRINGL(qstr, qlen);
+ efree(qstr);
+ return;
}
PDO_HANDLE_DBH_ERR();
RETURN_FALSE;