Re: cvs: php4 /ext/zip zip.c
| From: | Sterling Hughes | Date: | Fri, 12 Oct 2001 19:07:21 +0000 |
| Subject: | Re: cvs: php4 /ext/zip zip.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-7788@lists.php.net to get a copy of this message | ||
On Fri, 12 Oct 2001, Andrei Zmievski wrote:
> On Fri, 12 Oct 2001, Sterling Hughes wrote:
> > {
> > zval **r;
>
> This should be zval *r.
>
> > if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "r", &r) ==
> > FAILURE) {
> > return;
> > }
> > }
> >
> > Will cause a SIGSEGV (see bug report for zip extension in bug db).
> >
> > I've encountered this before, whenever using zend_parse_parameters
> > with a resource it segfaults at the :
> >
> > if (Z_TYPE_PP(arg) != IS_RESOURCE) {
> >
> > line.
>
> Try again.
>
Thanks, that looks like it will work, I'll revert + fix.
Can you explain why though?
-Sterling
> -Andrei
>
> "In this age, which believes that there is a short cut to everything,
> the greatest lesson to be learned is that the most difficult way is, in
> the long run, the easiest."
> -Henry Miller, The Books in My Life
>