Re: cvs: php4 /ext/yaz php_yaz.c
| From: | Sterling Hughes | Date: | Sat, 13 Oct 2001 16:55:21 +0000 |
| Subject: | Re: cvs: php4 /ext/yaz php_yaz.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-7796@lists.php.net to get a copy of this message | ||
On Sat, 13 Oct 2001, Adam Dickmeiss wrote:
> On Sat, Oct 13, 2001 at 04:55:40PM +0300, Jani Taskinen wrote:
> >
> > Are you sure this is necessary?
> > You just broke the thread-safe compile.
>
> Because of this?
Exactly.
> > >-static void yaz_close_link (zend_rsrc_list_entry *rsrc TSRMLS_DC)
> > >+static void yaz_close_link (zend_rsrc_list_entry *rsrc)
>
> Please explain. TSRMLS_DC is not defined in 4.0.6. Is it
> necessary?
>
yes, cvs version of extensions must work with the cvs version of
php.
-Sterling
> Cheers,
> Adam
>
> > --Jani
> >
> >
> > On Sat, 13 Oct 2001, Adam Dickmeiss wrote:
> >
> > >dickmeiss Sat Oct 13 03:38:31 2001 EDT
> > >
> > > Modified files:
> > > /php4/ext/yaz php_yaz.c
> > > Log:
> > > Fix backwards source compatibility.
> > >
> > >
> > >Index: php4/ext/yaz/php_yaz.c
> > >diff -u php4/ext/yaz/php_yaz.c:1.32 php4/ext/yaz/php_yaz.c:1.33
> > >--- php4/ext/yaz/php_yaz.c:1.32 Thu Oct 11 19:33:55 2001
> > >+++ php4/ext/yaz/php_yaz.c Sat Oct 13 03:38:31 2001
> > >@@ -16,7 +16,7 @@
> > > +----------------------------------------------------------------------+
> > > */
> > >
> > >-/* $Id: php_yaz.c,v 1.32 2001/10/11 23:33:55 ssb Exp $ */
> > >+/* $Id: php_yaz.c,v 1.33 2001/10/13 07:38:31 dickmeiss Exp $ */
> > >
> > > #ifdef HAVE_CONFIG_H
> > > #include "config.h"
> > >@@ -2609,7 +2609,7 @@
> > > }
> > > }
> > >
> > >-static void yaz_close_link (zend_rsrc_list_entry *rsrc TSRMLS_DC)
> > >+static void yaz_close_link (zend_rsrc_list_entry *rsrc)
> > > {
> > > Yaz_Association *as = (Yaz_Association *) rsrc->ptr;
> > > yaz_close_session (as);
> > >@@ -2678,7 +2678,9 @@
> > > }
> > >
> > > zend_module_entry yaz_module_entry = {
> > >+#if ZEND_MODULE_API_NO >= 20010901
> > > STANDARD_MODULE_HEADER,
> > >+#endif
> > > "yaz",
> > > yaz_functions,
> > > PHP_MINIT(yaz),
> > >@@ -2686,7 +2688,9 @@
> > > PHP_RINIT(yaz),
> > > PHP_RSHUTDOWN(yaz),
> > > PHP_MINFO(yaz),
> > >+#if ZEND_MODULE_API_NO >= 20010901
> > > NO_VERSION_YET,
> > >+#endif
> > > STANDARD_MODULE_PROPERTIES
> > > };
> > >
> > >
> > >
> > >
> > >
>
>