Re: com php-src: Fixed test (the expected output and master behavior are wrong): ext/reflection/tests/ReflectionProperty_setAccessible.phpt
| From: | Dmitry Stogov | Date: | Tue, 06 May 2014 23:36:50 +0000 |
| Subject: | Re: com php-src: Fixed test (the expected output and master behavior are wrong): ext/reflection/tests/ReflectionProperty_setAccessible.phpt | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-78164@lists.php.net to get a copy of this message | ||
I'll need to check it once again (already forgot the details).
Thanks for verifying :)
Dmitry.
On Wed, May 7, 2014 at 2:46 AM, Ferenc Kovacs <tyra3l@gmail.com> wrote:
>
>
>
> On Mon, Mar 17, 2014 at 2:55 PM, Dmitry Stogov <dmitry@php.net> wrote:
>
>> Commit: 77f4c9411445343192d93bdca60b0e82ec0126a5
>> Author: Dmitry Stogov <dmitry@zend.com> Mon, 17 Mar 2014
>> 17:55:51 +0400
>> Parents: 355b136466ae41eccd25e5a4f1ce16be9c9b9fd9
>> Branches: phpng
>>
>> Link:
>>
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=77f4c9411445343192d93bdca60b0e82ec0126a5
>>
>> Log:
>> Fixed test (the expected output and master behavior are wrong)
>>
>> Changed paths:
>> M ext/reflection/tests/ReflectionProperty_setAccessible.phpt
>>
>>
>> Diff:
>> diff --git a/ext/reflection/tests/ReflectionProperty_setAccessible.phpt
>> b/ext/reflection/tests/ReflectionProperty_setAccessible.phpt
>> index cc184c1..1e829b3 100644
>> --- a/ext/reflection/tests/ReflectionProperty_setAccessible.phpt
>> +++ b/ext/reflection/tests/ReflectionProperty_setAccessible.phpt
>> @@ -132,7 +132,7 @@ string(44) "Cannot access non-public member
>> B::protected"
>> string(50) "Cannot access non-public member B::protectedStatic"
>> string(42) "Cannot access non-public member A::private"
>> string(1) "a"
>> -string(1) "f"
>> +string(1) "b"
>> string(1) "c"
>> string(1) "e"
>> string(1) "f"
>>
>>
>> --
>> PHP CVS Mailing List (http://www.php.net/)
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
> are you sure?
> this tests seems to be untouched since it was added back in 2009.
> so I'm not sure what do you mean by master behavior.
>
> --
> Ferenc Kovács
> @Tyr43l - http://tyrael.hu
>