Re: com php-src: Re-added fix for bug #66015 and adapted for phpng branch: Zend/tests/bug66015.phpt Zend/tests/errmsg_040.phpt Zend/tests/ns_059.phpt
Zend/zend_API.c Zend/zend_ast.c Zend/zend_ast.h Zend/zend_compile.c Zend/zend_compile.h Zend/zend_execute_API.c Zend/zend_language_parser.y
Zend/zend_types.h Zend/zend_variables.c Zend/zend_vm_def.h Zend/zend_vm_execute.h ext/opcache/zend_accelerator_util_funcs.c ext/opcache/zend_persist.c
ext/opcache/z
| From: | Dmitry Stogov | Date: | Wed, 07 May 2014 07:45:52 +0000 |
| Subject: | Re: com php-src: Re-added fix for bug #66015 and adapted for phpng branch: Zend/tests/bug66015.phpt Zend/tests/errmsg_040.phpt Zend/tests/ns_059.phpt Zend/zend_API.c Zend/zend_ast.c Zend/zend_ast.h Zend/zend_compile.c Zend/zend_compile.h Zend/zend_execute_API.c Zend/zend_language_parser.y Zend/zend_types.h Zend/zend_variables.c Zend/zend_vm_def.h Zend/zend_vm_execute.h ext/opcache/zend_accelerator_util_funcs.c ext/opcache/zend_persist.c ext/opcache/z |
||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-78170@lists.php.net to get a copy of this message | ||
Actually, the patch looks good.
It was one simple mistake (wrong #endif placement in
zend_accelerator_util_funcs.c).
With fixed mistake it works fine.
I'll working with you patch right now (to understand all the details and
may be cleanup and optimize).
I'll most probably reapply it today or tomorrow.
Thanks. Dmitry.
On Wed, May 7, 2014 at 3:29 AM, Dmitry Stogov <dmitry@zend.com> wrote:
> Hi Bob,
>
> I had to revert you patch, because it break many tests when run with
> opcache.
> I'll work with you patch tomorrow, and then decide what to do.
>
> Thanks. Dmitry.
>
>
> On Tue, May 6, 2014 at 4:59 PM, Bob Weinand <bwoebi@php.net> wrote:
>
>> Commit: f3c1881f1dc19cb8bd0ddf0c85ecee390fde526f
>> Author: Bob Weinand <bobwei9@hotmail.com> Tue, 6 May 2014
>> 14:59:03 +0200
>> Parents: 485a60414de3b64e274aa60c93496d8bbfa2d8e5
>> Branches: phpng
>>
>> Link:
>>
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=f3c1881f1dc19cb8bd0ddf0c85ecee390fde526f
>>
>> Log:
>> Re-added fix for bug #66015 and adapted for phpng branch
>>
>> Bugs:
>> https://bugs.php.net/66015
>>
>> Changed paths:
>> M Zend/tests/bug66015.phpt
>> M Zend/tests/errmsg_040.phpt
>> M Zend/tests/ns_059.phpt
>> M Zend/zend_API.c
>> M Zend/zend_ast.c
>> M Zend/zend_ast.h
>> M Zend/zend_compile.c
>> M Zend/zend_compile.h
>> M Zend/zend_execute_API.c
>> M Zend/zend_language_parser.y
>> M Zend/zend_types.h
>> M Zend/zend_variables.c
>> M Zend/zend_vm_def.h
>> M Zend/zend_vm_execute.h
>> M ext/opcache/zend_accelerator_util_funcs.c
>> M ext/opcache/zend_persist.c
>> M ext/opcache/zend_persist_calc.c
>>
>>
>> --
>> PHP CVS Mailing List (http://www.php.net/)
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>
>