Re: com php-src: Going to refactor mysqlnd: ext/mysqlnd/mysqlnd.c ext/mysqlnd/mysqlnd_alloc.c ext/mysqlnd/mysqlnd_bt.c
ext/mysqlnd/mysqlnd_wireprotocol.c ext/pdo_mysql/mysql_driver.c

Hi Dmitry On 7.05.2014 19:00, Dmitry Stogov wrote:

Hi Andrey, Thanks for attention. Actually, I really like you to be involved into this development. Mysqlnd is a big and difficult part and you must know it better than anyone, after all, you'll have to support mysqlnd anyway.

I suppose the most trickiest part will be in the situations where mysqlnd plays with the reference counter to skip memory copies. However recently in 5.6 we added a second mode which doesn't reference but copies data, which is probably what phpng will want from mysqlnd, right?

Xinchen, I think, at first, we should implement support for all mysql extensions without mysqlnd.

Probably not a bad decision considering limiting the impact and getting something testable sooner. Best, Andrey

Thanks. Dmitry. On Wed, May 7, 2014 at 7:37 PM, Andrey Hristov <php@hristov.com> wrote:

Hi Xinchen, please don't remove the second line between the functions. I use it for better visibility (you may call me blind). Thanks! Andrey On 7.05.2014 18:34, Xinchen Hui wrote:

Commit:    37d9f1e6e91856922726fb950bd3f3e88ed68efb
Author:    Xinchen Hui <laruence@php.net>         Wed, 7 May 2014

23:34:23 +0800 Parents: 449ea00a48135e96a4f79841c4988c19ab1b58c0 Branches: phpng

Link:       http://git.php.net/?p=php-src.git;a=commitdiff;h=

37d9f1e6e91856922726fb950bd3f3e88ed68efb Log: Going to refactor mysqlnd Changed paths:

    M  ext/mysqlnd/mysqlnd.c
    M  ext/mysqlnd/mysqlnd_alloc.c
    M  ext/mysqlnd/mysqlnd_bt.c
    M  ext/mysqlnd/mysqlnd_wireprotocol.c
    M  ext/pdo_mysql/mysql_driver.c

-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php