com php-src: There is memleak: ext/skeleton/skeleton.c
| From: | Xinchen Hui | Date: | Thu, 08 May 2014 14:01:50 +0000 |
| Subject: | com php-src: There is memleak: ext/skeleton/skeleton.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-78216@lists.php.net to get a copy of this message | ||
Commit: 979c665f21dc9a75cddbcb30726b2f1325fb67e1
Author: Xinchen Hui <laruence@php.net> Thu, 8 May 2014 22:01:50 +0800
Parents: ebaee948d9b565b6af5b76aec2edf21ddce1de51
Branches: phpng
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=979c665f21dc9a75cddbcb30726b2f1325fb67e1
Log:
There is memleak
Changed paths:
M ext/skeleton/skeleton.c
Diff:
diff --git a/ext/skeleton/skeleton.c b/ext/skeleton/skeleton.c
index 3ba85d9..ef5aed4 100644
--- a/ext/skeleton/skeleton.c
+++ b/ext/skeleton/skeleton.c
@@ -44,7 +44,9 @@ PHP_FUNCTION(confirm_extname_compiled)
}
len = spprintf(&strg, 0, "Congratulations! You have successfully modified
ext/%.78s/config.m4. Module %.78s is now compiled into PHP.", "extname", arg);
- RETURN_STRINGL(strg, len);
+
+ RETVAL_STRINGL(strg, len);
+ efree(strg);
}
/* }}} */
/* The previous line is meant for vim and emacs, so it can correctly fold and