Re: com php-src: Update UPGRADING according to bug fix: UPGRADING

On Wed, May 14, 2014 at 9:49 AM, Ferenc Kovacs <tyra3l@gmail.com> wrote: > > > > On Mon, May 12, 2014 at 8:35 AM, Yasuo Ohgaki <yohgaki@php.net> wrote: > >> Commit: 2f9766fd02c061e89ae757760c2f2a432f1fe3a2 >> Author: Yasuo Ohgaki <yohgaki@php.net> Mon, 12 May 2014 >> 14:56:11 +0900 >> Parents: 89798f57d4a6552b08efeee24bf54079b072c771 >> Branches: PHP-5.6 master >> >> Link: >> >> http://git.php.net/?p=php-src.git;a=commitdiff;h=2f9766fd02c061e89ae757760c2f2a432f1fe3a2 >> >> Log: >> Update UPGRADING according to bug fix >> >> Changed paths: >> M UPGRADING >> >> >> Diff: >> diff --git a/UPGRADING b/UPGRADING >> index faf66d1..7a174c4 100755 >> --- a/UPGRADING >> +++ b/UPGRADING >> @@ -476,3 +476,5 @@ PHP 5.6 UPGRADE NOTES >> input_encoding >> output_encoding >> >> + The mb_regex_encoding() default setting is changed from EUC-JP to >> UTF-8. >> + >> >> >> -- >> PHP CVS Mailing List (http://www.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > shouldn't mb_regex_encoding default to php.input_encoding instead of > 'UTF-8'? > while testing this, I also noticed, that internal_encoding doesn't > defaults to default_charset, althought according to my understanding of the > original rfc, this should be the case: > > [tyrael@ferencs-mbp-135 php-src.git (PHP-5.6 ✗)]$ ./sapi/cli/php -n -r > 'var_dump(ini_get("internal_encoding"));' > string(0) "" > bringing this to internals@ for visibility. ps: if somebody wonders, this is related to https://wiki.php.net/rfc/default_encoding -- Ferenc Kovács @Tyr43l - http://tyrael.hu