Re: com php-src: Fix class constant fetching: Zend/tests/class_constant_to_reference_cached.phpt Zend/zend_execute.c Zend/zend_vm_def.h
Zend/zend_vm_execute.h
| From: | Dmitry Stogov | Date: | Thu, 29 May 2014 09:34:03 +0000 |
| Subject: | Re: com php-src: Fix class constant fetching: Zend/tests/class_constant_to_reference_cached.phpt Zend/zend_execute.c Zend/zend_vm_def.h Zend/zend_vm_execute.h |
||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-78629@lists.php.net to get a copy of this message | ||
Thanks. I saw the patch, but didn't check it yet.
BTW: I have one big improvement idea, that might correlate with the work
you made.
Currently, when we pass an argument to user php function, it's always
copied twice.
Once by SEND instruction, and then by RECV.
It means that we not only do the double work, but also keep two copies of
the same zval on VM stack.
I started thinking (in background yet) how it might be improved.
It's not going to be easy and may require significant redesign, but it must
make significant gain.
what do you think?
Thanks. Dmitry.
On Thu, May 29, 2014 at 1:24 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:
> On Thu, May 29, 2014 at 10:00 AM, Dmitry Stogov <dmitry@zend.com> wrote:
>
>> Hi Nikita,
>>
>> I didn't get. Should the new test fail?
>> May be some part wasn't committed.
>>
>> Thanks. Dmitry.
>>
>
> I've implemented an additional fix now, hopefully the test always passes
> now (even with opcache).
>
> Nikita
>