Re: com php-src: Fix ArrayObject with immutable array: ext/spl/spl_array.c

From: Date: Thu, 29 May 2014 19:57:43 +0000
Subject: Re: com php-src: Fix ArrayObject with immutable array: ext/spl/spl_array.c
References: 1 2 3  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-78642@lists.php.net to get a copy of this message
On Thu, May 29, 2014 at 9:52 PM, Nikita Popov <nikita.ppv@gmail.com> wrote: > On Thu, May 29, 2014 at 9:42 PM, Dmitry Stogov <dmitry@zend.com> wrote: > >> Hi Nikita, >> >> Please, don't make fast fixed for this problem. >> It might need a single general fix instead of fixes in thousands places. >> >> Can you provide a PHPT for the your fix? (email it) I'll need to analyze >> what did I miss. >> >> Thanks. Dmitry. >> > > I was getting an assertion failure, but I can't reproduce it anymore. So > this was probably a build issue that I didn't analyze correctly. I've > reverted the commit now. > > Nikita > I just checked, the SEPARATE_ZVAL_IF_NOT_REF macro was changed to account for immutability already, so this was definitely just a build artifact. Sorry about that. Nikita

« previous php.cvs (#78642) next »