com php-src: Avoid in-place modification: ext/simplexml/simplexml.c

From: Date: Fri, 30 May 2014 07:12:03 +0000
Subject: com php-src: Avoid in-place modification: ext/simplexml/simplexml.c
Groups: php.cvs 
Request: Send a blank email to php-cvs+get-78648@lists.php.net to get a copy of this message
Commit: 45d7ab1a4c323c50bc5007cf826540e62693db8c Author: Dmitry Stogov <dmitry@zend.com> Fri, 30 May 2014 11:12:03 +0400 Parents: b3b616cf7ee0702aca2f6fdb022dc7e28e015a22 Branches: phpng Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=45d7ab1a4c323c50bc5007cf826540e62693db8c Log: Avoid in-place modification Changed paths: M ext/simplexml/simplexml.c Diff: diff --git a/ext/simplexml/simplexml.c b/ext/simplexml/simplexml.c index f9f7452..1bcfec3 100644 --- a/ext/simplexml/simplexml.c +++ b/ext/simplexml/simplexml.c @@ -530,7 +530,12 @@ static int sxe_prop_dim_write(zval *object, zval *member, zval *value, zend_bool case IS_TRUE: case IS_DOUBLE: case IS_NULL: - convert_to_string(value); + if (Z_TYPE_P(value) != IS_STRING) { + ZVAL_DUP(&zval_copy, value); + value = &zval_copy; + convert_to_string(value); + new_value = 1; + } break; case IS_STRING: break;

« previous php.cvs (#78648) next »