Re: cvs: php4(PHP_4_0_7) /ext/standard http_fopen_wrapper.c
| From: | Edin Kadribasic | Date: | Fri, 19 Oct 2001 16:04:17 +0000 |
| Subject: | Re: cvs: php4(PHP_4_0_7) /ext/standard http_fopen_wrapper.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-7866@lists.php.net to get a copy of this message | ||
I shouldn't be so trigger happy :) Will read some docs and commit a fix very
soon.
Thanks,
Edin
----- Original Message -----
From: "Andrei Zmievski" <andrei@ispi.net>
To: "Edin Kadribasic" <edink@proventum.net>
Cc: <php-cvs@lists.php.net>
Sent: Friday, October 19, 2001 5:59 PM
Subject: Re: [PHP-CVS] cvs: php4(PHP_4_0_7) /ext/standard
http_fopen_wrapper.c
> On Fri, 19 Oct 2001, Edin Kadribasic wrote:
> > - strncat(new_path, resource->host,
sizeof(new_path)-strlen(new_path)-1);
> > + strlcat(new_path, resource->host,
sizeof(new_path)-strlen(new_path)-1);
>
> Is this correct? As far as I'm aware the last argument to strlcat()
> should be the size of the whole buffer.
>
> -Andrei
>
> "The day Microsoft makes something that doesn't suck,
> is probably the day Microsoft starts making vacuum cleaners."
> - Ernst Jan Plugge
>
>