Re: cvs: php4 /ext/pcre php_pcre.h /main SAPI.c
| From: | Rasmus Lerdorf | Date: | Sun, 21 Oct 2001 16:53:14 +0000 |
| Subject: | Re: cvs: php4 /ext/pcre php_pcre.h /main SAPI.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-7893@lists.php.net to get a copy of this message | ||
> > +char *php_pcre_replace(char *regex, int regex_len, char *subject, int
> subject_len,
> > + zval *replace_val, int is_callable_replace, int
> *result_len, int limit TSRMLS_DC);
>
> If sapi is using pcre from now on, I think that --without-pcre-regex
> configuration option should be removed since it's going to break the build:
That's a good point. What was the point of of that switch anyway? It's
not like the pcre library is all that large.
-rw-r--r-- 1 root root 41452 Oct 21 09:48 libpcre.a
Was there ever some functional reason for leaving it out? Does it not
compile everywhere? I don't see any recently reported bugs related to
that, so I think it should be ok to remove. Although, I could make the
code check for the presence and if it isn't there just do a stupid
replacement of the realm instead of trying to be smart about it. Perhaps
that is a better resolution.
-Rasmus