Re: com php-src: Bug 49898 __getCookies() method implementation: ext/soap/soap.c ext/soap/tests/bug49898.phpt
| From: | Stas Malyshev | Date: | Thu, 19 Jun 2014 00:38:22 +0000 |
| Subject: | Re: com php-src: Bug 49898 __getCookies() method implementation: ext/soap/soap.c ext/soap/tests/bug49898.phpt | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-78959@lists.php.net to get a copy of this message | ||
Hi!
> This is indeed a trivial and self-contained feature, but I think that
the "on a case by case basis" from
> https://wiki.php.net/rfc/releaseprocess
<https://wiki.php.net/rfc/releaseprocess>
should also mean some prior
discussion on the list.
This one looks rather trivial but if you see a need to discuss some
objections we can discuss them.
> My biggest issue is that allowing to frequent feature introduction
into stable branches means that we can't really have
It's not frequent at all. For the last 10 releases I can count barely
half-dozen additions.
This particular issue was filed 4.5 years ago and the pull was sitting
there for almost a year. I think it's enough time to wait for a trivial
and uncontroversial patch to get in, but if I'm wrong it's not too late
to discuss it. Again, I'm not advocating the general approach of commit
first and ask later, especially for substantial changes, but this was
out there for a long time and I don't see why anybody would object to it.
> feature freeze in a development branch, because it would make no sense
to have a new feature in X.Y.Z which isn't
> present in the X+1.0.0, even though that the latter was release later.
I'm not sure this minor thing qualifies as "feature" really, but if it's
a problem we can hold adding even a minor stuff for a while. I wouldn't
want to do it for a long time though, our turnaround time are already
not that great and pulls are sitting for months without anybody looking
at them. So when I have some time to look at them I'd like this time to
be productive. If you have any suggestions on how to improve the process
I'd be glad to hear them.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227