Re: com php-src: Add tests for constant expression arrays Adding one failing (!) test for now about circular constant references embedded in a
constant AST, must be fixed before PHP 5.6 release.: Zend/tests/constant_expressions_arrays.phpt
Zend/tests/constant_expressions_self_referencing_array.phpt
| From: | Nikita Popov | Date: | Wed, 02 Jul 2014 15:13:44 +0000 |
| Subject: | Re: com php-src: Add tests for constant expression arrays Adding one failing (!) test for now about circular constant references embedded in a constant AST, must be fixed before PHP 5.6 release.: Zend/tests/constant_expressions_arrays.phpt Zend/tests/constant_expressions_self_referencing_array.phpt |
||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-79200@lists.php.net to get a copy of this message | ||
On Wed, Jul 2, 2014 at 4:59 PM, Bob Weinand <bobwei9@hotmail.com> wrote:
> Am 2.7.2014 um 16:55 schrieb Nikita Popov <nikita.ppv@gmail.com>:
>
> Could you please mark the failing test as XFAIL?
>
> Nikita
>
>
> I intentionally marked that as FAIL to be sure that it won't be overseen
> upon PHP 5.6 release and remain unfixed.
> Or why has it to be XFAIL?
>
> Bob
>
If you don't mark it as XFAIL every new PR will see a red Travis build.
Also people not closely following internals will not spend time debugging
an already known issue or wonder whether their PHP build works correctly.
Nikita