Re: com php-src: Followup fix to custom session save handlers: ext/session/mod_user.c ext/session/session.c ext/session/tests/bug60634_error_1.phpt
ext/session/tests/bug60634_error_2.phpt ext/session/tests/save_handler.inc ext/session/tests/session_module_name_variation3.phpt
ext/session/tests/session_set_save_handler_class_002.phpt ext/session/tests/session_set_save_handler_class_005.phpt
ext/session/tests/session_set_save_handler_class_012.phpt ext
| From: | Yasuo Ohgaki | Date: | Mon, 07 Jul 2014 22:54:52 +0000 |
| Subject: | Re: com php-src: Followup fix to custom session save handlers: ext/session/mod_user.c ext/session/session.c ext/session/tests/bug60634_error_1.phpt ext/session/tests/bug60634_error_2.phpt ext/session/tests/save_handler.inc ext/session/tests/session_module_name_variation3.phpt ext/session/tests/session_set_save_handler_class_002.phpt ext/session/tests/session_set_save_handler_class_005.phpt ext/session/tests/session_set_save_handler_class_012.phpt ext |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-79311@lists.php.net to get a copy of this message | ||
Nice patch.
I didn't know there was RFC for this.
I was wishing to have this change for a long time :)
--
Yasuo Ohgaki
yohgaki@ohgaki.net
On Tue, Jul 8, 2014 at 4:59 AM, Sara Golemon <pollita@php.net> wrote:
> Commit: 7c2489751cc48961487edd69b49083d4ca6b4828
> Author: Sara Golemon <pollita@php.net> Mon, 7 Jul 2014
> 12:19:11 -0700
> Parents: 888fb3323ed1bb728064f27a6127d194eb92f9ee
> Branches: master
>
> Link:
>
> http://git.php.net/?p=php-src.git;a=commitdiff;h=7c2489751cc48961487edd69b49083d4ca6b4828
>
> Log:
> Followup fix to custom session save handlers
>
> 2d9885c introduced some regressions. This addresses those.
>
> * Don't throw return type notice or session write failure when in an
> exception
> * Fix tests to properly return true/false since null is no longer
> falsy/successy
> * Rerecord a few tests to accomodate difference in raised warnings
>
> Changed paths:
> M ext/session/mod_user.c
> M ext/session/session.c
> M ext/session/tests/bug60634_error_1.phpt
> M ext/session/tests/bug60634_error_2.phpt
> M ext/session/tests/save_handler.inc
> M ext/session/tests/session_module_name_variation3.phpt
> M ext/session/tests/session_set_save_handler_class_002.phpt
> M ext/session/tests/session_set_save_handler_class_005.phpt
> M ext/session/tests/session_set_save_handler_class_012.phpt
> M ext/session/tests/session_set_save_handler_class_016.phpt
> M ext/session/tests/session_set_save_handler_error3.phpt
> M ext/session/tests/session_set_save_handler_error4.phpt
> M ext/session/tests/session_set_save_handler_iface_001.phpt
> M ext/session/tests/session_set_save_handler_variation4.phpt
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>