Re: com php-src: Merge branch 'PHP-5.6': sapi/cli/php_cli_server.c

On 12 Jul, 2014, at 4:11 pm, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote: > Hi Tjerk, > > Thank you for the fix. > I should have noticed that you have been added lower cases keys in github discussion. > Original apache_request_headers() (I mean apache SAPI's function) does this also? > Then it would be ok. If not, I think adding lower cased key (header name) is too much > and cause confusion. Web SAPI functions should behave the same much as they can. I didn’t add anything that wasn’t already there; as the HTTP parser emits request header names they’re added into two hashes, one that stores the lowercased version and another that stores the original. The lowercased hash is probably used internally, I don’t really care; what I did do was rename both variables to better advertise what value they contain. > > > -- > Yasuo Ohgaki > yohgaki@ohgaki.net > > > On Sat, Jul 12, 2014 at 4:11 PM, Tjerk Anne Meesters <datibbaw@php.net> wrote: > Commit: 3a9bdafeff344543311e84436176625f4ce88b40 > Author: Tjerk Meesters <datibbaw@php.net> Sat, 12 Jul 2014 15:11:18 +0800 > Parents: 7de82eaeef24f3020610438877e375c9d35ac99c b3948b1d057a099b49cec95685e13fb0f56028c1 > Branches: master > > Link: > http://git.php.net/?p=php-src.git;a=commitdiff;h=3a9bdafeff344543311e84436176625f4ce88b40 > > Log: > Merge branch 'PHP-5.6' > > Changed paths: > MM sapi/cli/php_cli_server.c > > > Diff: > > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > >