Re: com php-src: brought back that vs2012 fix: ext/date/php_date.c

On Wed, Aug 20, 2014 at 11:38 AM, Derick Rethans <derick@php.net> wrote: > On Tue, 19 Aug 2014, Anatol Belski wrote: > >> Commit: d4f463cf0830de08c2b08557194883181a91fb08 >> Author: Anatol Belski <ab@php.net> Tue, 19 Aug 2014 09:37:38 +0200 >> Parents: 53c4c571b3d3b7891526ff616e69c4d74a04afe5 >> Branches: master >> >> Link: >> http://git.php.net/?p=php-src.git;a=commitdiff;h=d4f463cf0830de08c2b08557194883181a91fb08 >> >> Log: >> brought back that vs2012 fix >> >> Changed paths: >> M ext/date/php_date.c > > PLEASE do not only put this in master. It makes maintaining and > comparing it to PHP-5.5/PHP-5.6 a lot harder. However, these fixes are already in 5.5+. The difference in master is that buf is a zend_string not a char*. That being cleared, It is almost impossible to compare or use the same code base anyway. It will be painful and I yet have to figure out what's the best way to deal with that. Cheers, -- Pierre @pierrejoye | http://www.libgd.org