com php-src: fixed the test: ext/iconv/tests/iconv_strpos_v ariation3_64bit.phpt
| From: | Anatol Belski | Date: | Thu, 21 Aug 2014 11:49:09 +0000 |
| Subject: | com php-src: fixed the test: ext/iconv/tests/iconv_strpos_v ariation3_64bit.phpt | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-80709@lists.php.net to get a copy of this message | ||
Commit: 79b2852da4c630f9f0e5887e5bc0b8b46faac82b
Author: Anatol Belski <ab@php.net> Thu, 21 Aug 2014 13:49:09 +0200
Parents: 307dac3cfd3bcacf0b1e678e64e910fd1c21bf07
Branches: master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=79b2852da4c630f9f0e5887e5bc0b8b46faac82b
Log:
fixed the test
the cause for this to fail now was that _php_iconv_strpos had int for
the offset, but the int from userland is 64 bit, that was an overflow
cusing wrong behaviour
Changed paths:
M ext/iconv/tests/iconv_strpos_variation3_64bit.phpt
Diff:
diff --git a/ext/iconv/tests/iconv_strpos_variation3_64bit.phpt
b/ext/iconv/tests/iconv_strpos_variation3_64bit.phpt
index 1cc8a84..f1807cc 100644
--- a/ext/iconv/tests/iconv_strpos_variation3_64bit.phpt
+++ b/ext/iconv/tests/iconv_strpos_variation3_64bit.phpt
@@ -130,7 +130,7 @@ Warning: iconv_strpos(): Offset not contained in string. in %s on line %d
bool(false)
-- Iteration 7 --
-int(8)
+bool(false)
-- Iteration 8 --
int(8)
@@ -196,4 +196,4 @@ int(8)
Warning: iconv_strpos() expects parameter 3 to be long, resource given in %s on line %d
bool(false)
-Done
\ No newline at end of file
+Done