com php-src: Hack around global leak for now: Zend/zend_compi le.c
| From: | Nikita Popov | Date: | Fri, 04 Jul 2014 21:15:31 +0000 |
| Subject: | com php-src: Hack around global leak for now: Zend/zend_compi le.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-81026@lists.php.net to get a copy of this message | ||
Commit: b3336270f65df79d92d2f751f4276893d77720e2
Author: Nikita Popov <nikic@php.net> Fri, 4 Jul 2014 23:15:31 +0200
Parents: fdc318849a045dc3538667841ba819fbf40a8c0a
Branches: master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=b3336270f65df79d92d2f751f4276893d77720e2
Log:
Hack around global leak for now
Changed paths:
M Zend/zend_compile.c
Diff:
diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c
index 239e8f0..925527e 100644
--- a/Zend/zend_compile.c
+++ b/Zend/zend_compile.c
@@ -6914,11 +6914,9 @@ void zend_compile_global_var(zend_ast *ast TSRMLS_DC) {
}
opline = emit_op(&result, ZEND_FETCH_W, &var_node, NULL TSRMLS_CC);
- opline->extended_value = ZEND_FETCH_GLOBAL_LOCK;
- if (var_node.op_type == IS_CONST) {
- //zval_copy_ctor(&var_node.u.constant);
- }
+ // TODO.AST Avoid double fetch
+ //opline->extended_value = ZEND_FETCH_GLOBAL_LOCK;
zend_ast *fetch_ast = zend_ast_create_unary(ZEND_AST_VAR, var_ast);
zend_compile_assign_ref_common(NULL, fetch_ast, &result TSRMLS_CC);