Re: com php-src: fixes to string functions: ext/standard/php_string.h ext/standard/string.c
| From: | Nikita Popov | Date: | Tue, 26 Aug 2014 23:32:41 +0000 |
| Subject: | Re: com php-src: fixes to string functions: ext/standard/php_string.h ext/standard/string.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-81144@lists.php.net to get a copy of this message | ||
On Mon, Aug 18, 2014 at 3:39 PM, Anatol Belski <ab@php.net> wrote:
> Commit: 97e9d058f09c12161863e5c3832552eb5da3f3c6
> Author: Anatol Belski <ab@php.net> Mon, 18 Aug 2014 15:39:38
> +0200
> Parents: 22dbb38d5e234f5987e226298ba9b86d9f9ea52a
> Branches: master
>
> Link:
> ±÷îÅÉ€½#_
> ŸF±vhttp://git.php.net/?p=php-src.git;a=commitdiff;h=97e9d058f09c12161863e5c3832552eb5da3f3c6
>
> Log:
> fixes to string functions
>
> Changed paths:
> M ext/standard/php_string.h
> M ext/standard/string.c
>
The changes here related to using STR_INIT for a zpp default value won't
work correctly (also including followup changes). The way it is currently
implemented you will still get leaks (e.g. if the str_pad default *is*
used) or segfaults (if zpp fails after assigning the pad value).
I would suggest reverting the STR_INIT related changes altogether, or if
you want to use this approach, then the zend_string for the default value
should be allocated on startup and destroyed on shutdown.
Nikita