Re: com php-src: Port iconv (all tests passes): ext/iconv/iconv.c ext/iconv/php_iconv.h ext/standard/php_smart_str.h

Hey: I am looking at it now.. thanks On Thu, Aug 28, 2014 at 10:59 AM, Xinchen Hui <laruence@php.net> wrote: > Hey: > > > On Thu, Aug 28, 2014 at 6:40 AM, Dmitry Stogov <dmitry@zend.com> wrote: >> Hi Xinchen, >> >> any idea where that code came from? > No idea... > > Johannes, does php-5.6 iconv works fine for you? > > thanks >> >> Thanks. Dmitry. >> >> >> On Thu, Aug 28, 2014 at 2:01 AM, Johannes Schlüter <johannes@schlueters.de> >> wrote: >>> >>> Hi, >>> >>> On Mon, 2014-05-05 at 05:58 +0000, Dmitry Stogov wrote: >>> > +#elif defined(NETWARE) >>> > + iconv_impl = "Novell"; >>> > + version = "OS built-in"; >>> > +#else >>> > + iconv_impl = "unknown"; >>> > + version = (char *)gnu_get_libc_version(); >>> > +#endif >>> >>> on Solaris using system iconv this leads to >>> >>> Undefined first referenced >>> symbol in file >>> gnu_get_libc_version ext/iconv/.libs/iconv.o >>> ld: fatal: symbol referencing errors >>> >>> configure says >>> >>> checking for iconv support... yes >>> checking for iconv... yes >>> checking if iconv is glibc's... no >>> checking if using GNU libiconv... no >>> checking if iconv is Konstantin Chuguev's... no >>> checking if using IBM iconv... no >>> checking if iconv supports errno... no >>> >>> I haven't checked further. >>> >>> johannes >>> >> > > > > -- > Xinchen Hui > @Laruence > http://www.laruence.com/ -- Xinchen Hui @Laruence http://www.laruence.com/