Re: com php-src: Fixed return operand type (Use IS_TMP_VAR instead of IS_VAR in the same way as it was before AST patch): Zend/zend_compile.c
ext/opcache/Optimizer/pass1_5.c
| From: | Nikita Popov | Date: | Wed, 03 Sep 2014 12:26:16 +0000 |
| Subject: | Re: com php-src: Fixed return operand type (Use IS_TMP_VAR instead of IS_VAR in the same way as it was before AST patch): Zend/zend_compile.c ext/opcache/Optimizer/pass1_5.c |
||
| References: | 1 2 3 4 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-81400@lists.php.net to get a copy of this message | ||
On Wed, Sep 3, 2014 at 2:08 PM, Dmitry Stogov <dmitry@zend.com> wrote:
> https://gist.github.com/dstogov/bbfe39c387580d42d458
>
> Do you think this fix is enough?
>
> Thanks. Dmitry.
>
Yes, this looks fine, I'd also do it this way. Was mainly concerned about
whether it's okay to just disallow it, as it forbids code that previously
ran without any errors/warnings (the =& strlen() case).
Nikita