com php-src: Bug #67965: Fix blocking behavior in non-blocking crypto streams: ext/openssl/xp_ssl.c
| From: | rdlowrey@php.net | Date: | Tue, 09 Sep 2014 13:37:57 +0000 |
| Subject: | com php-src: Bug #67965: Fix blocking behavior in non-blocking crypto streams: ext/openssl/xp_ssl.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-81476@lists.php.net to get a copy of this message | ||
Commit: f86b2193a483f56b0bd056570a0cdb57ebe66e2f
Author: Daniel Lowrey <rdlowrey@php.net> Tue, 9 Sep 2014 07:37:57 -0600
Parents: 99f0760bfba86f45af9ea011a0f017080922710a
Branches: PHP-5.4
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=f86b2193a483f56b0bd056570a0cdb57ebe66e2f
Log:
Bug #67965: Fix blocking behavior in non-blocking crypto streams
Bugs:
https://bugs.php.net/67965
Changed paths:
M ext/openssl/xp_ssl.c
Diff:
diff --git a/ext/openssl/xp_ssl.c b/ext/openssl/xp_ssl.c
index 956ffd0..76095b4 100644
--- a/ext/openssl/xp_ssl.c
+++ b/ext/openssl/xp_ssl.c
@@ -871,17 +871,19 @@ static int php_openssl_sockop_cast(php_stream *stream, int castas, void **ret
TS
case PHP_STREAM_AS_FD_FOR_SELECT:
if (ret) {
- if (sslsock->ssl_active) {
- /* OpenSSL has an internal buffer which select() cannot see. If we don't
- fetch it into the stream's buffer, no activity will be reported on the
- stream even though there is data waiting to be read - but we only fetch
- the number of bytes OpenSSL has ready to give us since we weren't asked
- for any data at this stage. This is only likely to cause issues with
- non-blocking streams, but it's harmless to always do it. */
- int bytes;
- while ((bytes = SSL_pending(sslsock->ssl_handle)) > 0) {
- php_stream_fill_read_buffer(stream, (size_t)bytes);
- }
+ /* OpenSSL has an internal buffer which select() cannot see. If we don't
+ * fetch it into the stream's buffer, no activity will be reported on the
+ * stream even though there is data waiting to be read - but we only fetch
+ * the lower of bytes OpenSSL has ready to give us or chunk_size since we
+ * weren't asked for any data at this stage. This is only likely to cause
+ * issues with non-blocking streams, but it's harmless to always do it. */
+ size_t pending;
+ if (stream->writepos == stream->readpos
+ && sslsock->ssl_active
+ && (pending = (size_t)SSL_pending(sslsock->ssl_handle)) > 0) {
+ php_stream_fill_read_buffer(stream, pending < stream->chunk_size
+ ? pending
+ : stream->chunk_size);
}
*(int *)ret = sslsock->s.socket;