Re: com php-src: second big shot on porting ext/oci8: ext/oci8/oci8.c ext/oci8/oci8_collection.c ext/oci8/oci8_interface.c ext/oci8/oci8_lob.c
ext/oci8/oci8_statement.c ext/oci8/php_oci8_int.h
| From: | Nikita Popov | Date: | Wed, 10 Sep 2014 10:52:39 +0000 |
| Subject: | Re: com php-src: second big shot on porting ext/oci8: ext/oci8/oci8.c ext/oci8/oci8_collection.c ext/oci8/oci8_interface.c ext/oci8/oci8_lob.c ext/oci8/oci8_statement.c ext/oci8/php_oci8_int.h |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-81488@lists.php.net to get a copy of this message | ||
On Wed, Sep 10, 2014 at 12:41 PM, Anatol Belski <ab@php.net> wrote:
> Commit: e3ded277a5f9582fbbbc1bf68d9b8145aa9a5afb
> Author: Anatol Belski <ab@php.net> Wed, 10 Sep 2014 12:40:32
> +0200
> Parents: 686213a2425f4b364cae8efdf4b07ccb203b9504
> Branches: master
>
> Link:
>
> http://git.php.net/?p=php-src.git;a=commitdiff;h=e3ded277a5f9582fbbbc1bf68d9b8145aa9a5afbqÝEs#Ö®7„`EE¼�
>
>
> Log:
> second big shot on porting ext/oci8
>
> still a lot to do, but most raw things done
>
> Changed paths:
> M ext/oci8/oci8.c
> M ext/oci8/oci8_collection.c
> M ext/oci8/oci8_interface.c
> M ext/oci8/oci8_lob.c
> M ext/oci8/oci8_statement.c
> M ext/oci8/php_oci8_int.h
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>
+
memcmp(tmp->hash_key->val, hashed_details.s->val, tmp->hash_key->len) == 0
&& ++GC_REFCOUNT(connection->id) == SUCCESS) {
Comparing GC_REFCOUNT to SUCCESS, that doesn't seem right.
+ if ((tmp = zend_hash_find(Z_OBJPROP_P(z_descriptor),
zend_string_init("descriptor", sizeof("descriptor"), 0))) == NULL) {
String initialized with sizeof instead of sizeof-1. Furthermore you're
leaking the string. Better use zend_hash_str_find, it will avoid allocating
a zend_string.
Nikita