com php-src: Mark three foreach tests as XFAIL: tests/lang/foreachLoop.013.phpt tests/lang/foreachLoop.014.phpt tests/lang/foreachLoop.015.phpt
| From: | Nikita Popov | Date: | Fri, 03 Oct 2014 20:02:02 +0000 |
| Subject: | com php-src: Mark three foreach tests as XFAIL: tests/lang/foreachLoop.013.phpt tests/lang/foreachLoop.014.phpt tests/lang/foreachLoop.015.phpt | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-82083@lists.php.net to get a copy of this message | ||
Commit: 5831cca9576f4e0d4daed75a9915d436dfc5f4e5
Author: Nikita Popov <nikic@php.net> Fri, 3 Oct 2014 21:46:14 +0200
Parents: d2161c8104df33adf8a3e20168cdf9af5f0ade88
Branches: master
Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=5831cca9576f4e0d4daed75a9915d436dfc5f4e5
Log:
Mark three foreach tests as XFAIL
A lot of work is needed to properly handle all foreach edge cases,
which is not going to happen anytime soon. So marking these tests
as XFAIL for now.
Changed paths:
M tests/lang/foreachLoop.013.phpt
M tests/lang/foreachLoop.014.phpt
M tests/lang/foreachLoop.015.phpt
Diff:
diff --git a/tests/lang/foreachLoop.013.phpt b/tests/lang/foreachLoop.013.phpt
index 3dec119..b0c5e8d 100644
--- a/tests/lang/foreachLoop.013.phpt
+++ b/tests/lang/foreachLoop.013.phpt
@@ -1,5 +1,7 @@
--TEST--
Directly modifying an unreferenced array when foreach'ing over it while using &$value
syntax.
+--XFAIL--
+Needs major foreach changes to get sane behavior
--FILE--
<?php
diff --git a/tests/lang/foreachLoop.014.phpt b/tests/lang/foreachLoop.014.phpt
index ab3c657..d32ea63 100644
--- a/tests/lang/foreachLoop.014.phpt
+++ b/tests/lang/foreachLoop.014.phpt
@@ -1,5 +1,7 @@
--TEST--
Directly modifying a REFERENCED array when foreach'ing over it.
+--XFAIL--
+Needs major foreach changes to get sane behavior
--FILE--
<?php
@@ -553,4 +555,4 @@ array(10) {
string(3) "v.2"
[9]=>
string(3) "v.3"
-}
\ No newline at end of file
+}
diff --git a/tests/lang/foreachLoop.015.phpt b/tests/lang/foreachLoop.015.phpt
index dfba159..5b12a2b 100644
--- a/tests/lang/foreachLoop.015.phpt
+++ b/tests/lang/foreachLoop.015.phpt
@@ -1,5 +1,7 @@
--TEST--
Directly modifying a REFERENCED array when foreach'ing over it while using &$value syntax.
+--XFAIL--
+Needs major foreach changes to get sane behavior
--FILE--
<?php