Re: com php-src: Fixed bug #66242 (don't assume char is signed): ext/fileinfo/libmagic/apprentice.c

On 15 October 2014 07:16, Remi Collet <remi@fedoraproject.org> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Le 21/09/2014 01:39, Ard Biesheuvel a écrit : >> Commit: e64da8c20df3ec28bd2417924b207b870e9ab99f Author: Ard >> Biesheuvel <ard.biesheuvel@linaro.org> Sat, 20 Sep 2014 >> 16:32:31 -0700 Parents: 00525b824af4265e7fc74d3655a04da9c4c667f7 >> Branches: PHP-5.4 PHP-5.5 PHP-5.6 master >> >> Link: >> >> http://git.php.net/?p=php-src.git;a=commitdiff;h=e64da8c20df3ec28bd2417924b207b870e9ab99f >> >> Log: Fixed bug #66242 (don't assume char is signed) >> >> This fixes a bug in libmagic where a cast to 'char' is assumed to >> result in sign extension to occur. However, unqualified 'char' is >> unsigned on architectures such as ARM, so the cast needs to be to >> 'signed char' explicitly. >> >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> >> Bugs: https://bugs.php.net/66242 > > This bug should really be fixed upstream (libmagic), else, on next > update it will be very probably lost. > > See https://github.com/file/file > > I have send this information to upstream. > You are right. Thanks for sharing this with the upstream maintainer. -- Ard.