Re: com php-src: Fixed bug #68331 - This was partial patch for https://wiki.php.net/rfc/session-lock-ini: ext/session/session.c
ext/session/tests/session_set_save_handler_write_short_circuit.phpt

Hi Stas, It's unneeded at all for the branch. I'll clean it up. Thank you. -- Yasuo Ohgaki yohgaki@ohgaki.net On Wed, Nov 12, 2014 at 10:04 AM, Ferenc Kovacs <tyra3l@gmail.com> wrote: > > > On Thu, Nov 6, 2014 at 9:48 AM, Stas Malyshev <smalyshev@gmail.com> wrote: > >> Hi! >> > Commit: 4dd3fbfcd28f8a3826361c5c4b7aa4c4da592b22 >> > Author: Yasuo Ohgaki <yohgaki@php.net> Thu, 6 Nov 2014 >> 13:06:29 +0900 >> > Parents: d4050f42fd89e30a4efb2bda5845dae51e7dc87a >> > Branches: PHP-5.6 >> > >> > Link: >> …¯« >> ç«v¤0ÓDc’khttp://git.php.net/?p=php-src.git;a=commitdiff;h=4dd3fbfcd28f8a3826361c5c4b7aa4c4da592b22 >> > >> > Log: >> > Fixed bug #68331 - This was partial patch for >> https://wiki.php.net/rfc/session-lock-ini >> > >> > Bugs: >> > https://bugs.php.net/68331 >> > >> > Changed paths: >> > M ext/session/session.c >> > M ext/session/tests/session_set_save_handler_write_short_circuit.phpt >> I'm not sure I fully understand the patch - if you removed the MD5 >> calculation at initialize and check, why you have left the MD5 >> calculation at save? >> >> >> -- >> PHP CVS Mailing List (http://www.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > bump, it seems that this is still there, Yasuo, could you please remove > the md5 part also? > > -- > Ferenc Kovács > @Tyr43l - http://tyrael.hu >